Skip to content

chore(32662): Add matrix-based jobs for Percy #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 12, 2025
Merged

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented May 8, 2025

See https://hivemq.kanbanize.com/ctrl_board/57/cards/32662/details/

The PR is an extension of the previous refactoring of the frontend CI pipeline, see #960

It deprecates the old, standalone workflow for visual testing (performed with Percy) and integrates an improved version of the existing Cypress-based matrix of tests. Since the Cypress matrix is already streamlined for performing tests and code coverage, the job has been extended with the prefixed command required for Percy to perform visual tests from the existing Cypress suites. There is no need for a second, costly pass through the tests.

Before

Screenshot 2025-05-12 at 09 58 52

After

Screenshot 2025-05-12 at 09 58 28

@vanch3d vanch3d self-assigned this May 8, 2025
@cla-bot cla-bot bot added the cla-signed label May 8, 2025
@vanch3d vanch3d force-pushed the chore/32855-percy branch from d16a9b0 to 98b440e Compare May 9, 2025 10:11
@vanch3d vanch3d force-pushed the chore/32855-percy branch from 98b440e to efaf68c Compare May 9, 2025 15:44
@vanch3d vanch3d marked this pull request as ready for review May 9, 2025 18:22
Copy link
Contributor

@oli-hivemq oli-hivemq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦣

@vanch3d vanch3d merged commit 2ecc0b5 into master May 12, 2025
18 checks passed
@vanch3d vanch3d deleted the chore/32855-percy branch May 12, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants