Skip to content

[deps] Allow transformers <5.0.0 for Qwen3-VL#663

Merged
hiyouga merged 4 commits intohiyouga:mainfrom
rank-Yu:main
Mar 10, 2026
Merged

[deps] Allow transformers <5.0.0 for Qwen3-VL#663
hiyouga merged 4 commits intohiyouga:mainfrom
rank-Yu:main

Conversation

@rank-Yu
Copy link
Copy Markdown
Contributor

@rank-Yu rank-Yu commented Mar 9, 2026

This PR is for #580.

When installing with pip install -e ., the current constraint transformers<=4.57.0 does not support Qwen3-VL.

In addition, transformers==4.57.0 has been yanked from PyPI, which may cause installation issues depending on the resolver.

This PR relaxes the constraint to transformers<5.0.0, allowing newer versions of transformers that support Qwen3-VL.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a dependency conflict that prevented the successful installation of Qwen3-VL. By broadening the acceptable version range for the transformers library, it ensures that users can install the necessary components without encountering version-related errors, thereby improving the overall compatibility and usability of the system.

Highlights

  • Dependency Update: The transformers dependency version constraint has been updated to allow versions less than 5.0.0, specifically transformers>=4.54.0,<5.0.0.
  • Qwen3-VL Compatibility: This change addresses an installation issue for Qwen3-VL, which was previously incompatible with the stricter transformers<=4.57.0 constraint.
Changelog
  • requirements.txt
    • Updated the version constraint for the transformers package to allow versions up to, but not including, 5.0.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates the transformers dependency version. While the change in requirements.txt is correct, I've identified a critical inconsistency with the project's Dockerfile. The Dockerfile uses a different, less restrictive version constraint for transformers, which could lead to future build failures or runtime issues. My review includes a recommendation to align these dependencies for better stability and maintainability.

Note: Security Review has been skipped due to the limited scope of the PR.

Comment thread requirements.txt
@hiyouga hiyouga merged commit a354cdc into hiyouga:main Mar 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants