[deps] Allow transformers <5.0.0 for Qwen3-VL#663
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a dependency conflict that prevented the successful installation of Qwen3-VL. By broadening the acceptable version range for the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR updates the transformers dependency version. While the change in requirements.txt is correct, I've identified a critical inconsistency with the project's Dockerfile. The Dockerfile uses a different, less restrictive version constraint for transformers, which could lead to future build failures or runtime issues. My review includes a recommendation to align these dependencies for better stability and maintainability.
Note: Security Review has been skipped due to the limited scope of the PR.
This PR is for #580.
When installing with
pip install -e ., the current constrainttransformers<=4.57.0does not support Qwen3-VL.In addition,
transformers==4.57.0has been yanked from PyPI, which may cause installation issues depending on the resolver.This PR relaxes the constraint to
transformers<5.0.0, allowing newer versions of transformers that support Qwen3-VL.