Skip to content

support new processor arg video_maxlen_ttl #7810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Luffy-ZY-Wang
Copy link

@Luffy-ZY-Wang Luffy-ZY-Wang commented Apr 22, 2025

What does this PR do?

Fixes #7693
Replace #7700 (too many changes in it to check, so open this PR with a new branch)

Before submitting

@hiyouga hiyouga added the pending This problem is yet to be addressed label Apr 22, 2025
@Luffy-ZY-Wang Luffy-ZY-Wang marked this pull request as draft April 23, 2025 02:55
@Luffy-ZY-Wang Luffy-ZY-Wang force-pushed the new_branch_video_len_ttl branch from fa88b70 to fdf61aa Compare April 23, 2025 03:29
@Luffy-ZY-Wang Luffy-ZY-Wang marked this pull request as ready for review April 23, 2025 03:31
@Luffy-ZY-Wang
Copy link
Author

When I run HF_ENDPOINT=https://hf-mirror.com make test, I encountered these errors:

========================================================================================================= short test summary info ==========================================================================================================
FAILED tests/data/processor/test_unsupervised.py::test_unsupervised_data[16] - ValueError: PPO only accepts wandb or tensorboard logger.
FAILED tests/e2e/test_chat.py::test_chat - AssertionError: assert '/raw' == '_rho'
  
  - _rho
  + /raw
FAILED tests/e2e/test_chat.py::test_stream_chat - AssertionError: assert '़़े़ें' == '_rho'
  
  - _rho
  + ़़े़ें 
FAILED tests/model/model_utils/test_add_tokens.py::test_add_tokens[False] - TypeError: ModelArguments.__init__() got an unexpected keyword argument 'add_tokens'
FAILED tests/model/model_utils/test_add_tokens.py::test_add_tokens[True] - TypeError: ModelArguments.__init__() got an unexpected keyword argument 'add_special_tokens'
========================================================================= 5 failed, 107 passed, 10 skipped, 6 xfailed, 1 xpassed, 7 warnings in 351.15s (0:05:51) ==========================================================================
make: *** [Makefile:24: test] Error 1

I still don't know why this would happen. Do you have any ideas? @hiyouga

@Luffy-ZY-Wang
Copy link
Author

After updating transformers,

$ pip show transformers
Name: transformers
Version: 4.51.3
Summary: State-of-the-art Machine Learning for JAX, PyTorch and TensorFlow
Home-page: https://github.com/huggingface/transformers
Author: The Hugging Face team (past and future) with the help of all our contributors (https://github.com/huggingface/transformers/graphs/contributors)
Author-email: [email protected]
License: Apache 2.0 License
Location: /home/phd-chen.yirong2/anaconda3/envs/vllm/lib/python3.12/site-packages
Requires: filelock, huggingface-hub, numpy, packaging, pyyaml, regex, requests, safetensors, tokenizers, tqdm
Required-by: compressed-tensors, llamafactory, peft, trl, vllm, xgrammar

these 3 errors still remain:

========================================================================================================= short test summary info ==========================================================================================================
FAILED tests/data/processor/test_unsupervised.py::test_unsupervised_data[16] - ValueError: PPO only accepts wandb or tensorboard logger.
FAILED tests/model/model_utils/test_add_tokens.py::test_add_tokens[False] - TypeError: ModelArguments.__init__() got an unexpected keyword argument 'add_tokens'
FAILED tests/model/model_utils/test_add_tokens.py::test_add_tokens[True] - TypeError: ModelArguments.__init__() got an unexpected keyword argument 'add_special_tokens'
========================================================================== 3 failed, 110 passed, 9 skipped, 5 xfailed, 2 xpassed, 7 warnings in 328.52s (0:05:28) ==========================================================================
make: *** [Makefile:24: test] Error 1

@Luffy-ZY-Wang
Copy link
Author

Sorry for not applying pip install -e .[dev].
But 1 error still remains after that:

========================================================================================================= short test summary info ==========================================================================================================
FAILED tests/data/processor/test_unsupervised.py::test_unsupervised_data[16] - ValueError: PPO only accepts wandb or tensorboard logger.
========================================================================== 1 failed, 112 passed, 9 skipped, 5 xfailed, 2 xpassed, 7 warnings in 323.25s (0:05:23) ==========================================================================
make: *** [Makefile:24: test] Error 1

@Luffy-ZY-Wang Luffy-ZY-Wang marked this pull request as draft April 23, 2025 04:29
@Luffy-ZY-Wang
Copy link
Author

Luffy-ZY-Wang commented Apr 23, 2025

Sorry for not applying pip install -e .[dev]. But 1 error still remains after that:

========================================================================================================= short test summary info ==========================================================================================================
FAILED tests/data/processor/test_unsupervised.py::test_unsupervised_data[16] - ValueError: PPO only accepts wandb or tensorboard logger.
========================================================================== 1 failed, 112 passed, 9 skipped, 5 xfailed, 2 xpassed, 7 warnings in 323.25s (0:05:23) ==========================================================================
make: *** [Makefile:24: test] Error 1

This error disappears with transformers== 4.49.0.
Now I'm working to add some tests regarding this PR in test_mm_plugin.py.

@Luffy-ZY-Wang Luffy-ZY-Wang force-pushed the new_branch_video_len_ttl branch from fdf61aa to 140adb4 Compare April 23, 2025 10:18
@Luffy-ZY-Wang Luffy-ZY-Wang marked this pull request as ready for review April 29, 2025 04:25
@Luffy-ZY-Wang Luffy-ZY-Wang marked this pull request as draft April 29, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending This problem is yet to be addressed
Projects
None yet
2 participants