Skip to content

fix(data): wrap MiniMax-M2 tool calls in <minimax:tool_call> tags #10586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
he-yufeng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(data): wrap MiniMax-M2 tool calls in <minimax:tool_call> tags #10586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/llamafactory/data/tool_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ def function_formatter(functions: list["FunctionCall"]) -> str:
prompt += "\n</invoke>"
function_texts.append(prompt)

return "\n".join(function_texts)
return "<minimax:tool_call>\n" + "\n".join(function_texts) + "\n</minimax:tool_call>"

@override
@staticmethod
Expand Down
48 changes: 48 additions & 0 deletions tests/data/test_formatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,54 @@ def test_qwen_multi_tool_extractor():
]


@pytest.mark.runs_on(["cpu", "mps"])
def test_minimax2_function_formatter():
formatter = FunctionFormatter(slots=["{{content}}"], tool_format="minimax2")
tool_calls = json.dumps(FUNCTION)
assert formatter.apply(content=tool_calls) == [
"<minimax:tool_call>\n"
'<invoke name="tool_name">\n'
'<parameter name="foo">bar</parameter>\n'
'<parameter name="size">10</parameter>\n'
"</invoke>\n"
"</minimax:tool_call>"
]


@pytest.mark.runs_on(["cpu", "mps"])
def test_minimax2_multi_function_formatter():
formatter = FunctionFormatter(slots=["{{content}}"], tool_format="minimax2")
tool_calls = json.dumps([FUNCTION] * 2)
invoke = '<invoke name="tool_name">\n<parameter name="foo">bar</parameter>\n<parameter name="size">10</parameter>\n</invoke>'
assert formatter.apply(content=tool_calls) == [f"<minimax:tool_call>\n{invoke}\n{invoke}\n</minimax:tool_call>"]


@pytest.mark.runs_on(["cpu", "mps"])
def test_minimax2_tool_extractor():
formatter = ToolFormatter(tool_format="minimax2")
result = (
"<minimax:tool_call>\n"
'<invoke name="test_tool">\n'
'<parameter name="foo">bar</parameter>\n'
'<parameter name="size">10</parameter>\n'
"</invoke>\n"
"</minimax:tool_call>"
)
assert formatter.extract(result) == [("test_tool", """{"foo": "bar", "size": 10}""")]


@pytest.mark.runs_on(["cpu", "mps"])
def test_minimax2_tool_round_trip():
formatter = FunctionFormatter(slots=["{{content}}"], tool_format="minimax2")
tool_formatter = ToolFormatter(tool_format="minimax2")
original = {"name": "my_func", "arguments": {"arg1": "hello", "arg2": 42, "arg3": True}}
formatted = formatter.apply(content=json.dumps(original))
extracted = tool_formatter.extract(formatted[0])
assert len(extracted) == 1
assert extracted[0][0] == original["name"]
assert json.loads(extracted[0][1]) == original["arguments"]


@pytest.mark.runs_on(["cpu", "mps"])
def test_lfm2_function_formatter():
formatter = FunctionFormatter(slots=["{{content}}<|im_end|>\n"], tool_format="lfm2")
Expand Down