fix(data): correct keyword argument sample_idx to batch_idx in collator#10612
Open
GSCSD1 wants to merge 1 commit into
Open
fix(data): correct keyword argument sample_idx to batch_idx in collator#10612GSCSD1 wants to merge 1 commit into
sample_idx to batch_idx in collator#10612GSCSD1 wants to merge 1 commit into
Conversation
…slice_mm_inputs_for_sample` call The function signature uses `batch_idx` as the parameter name, but the call at line 263 passed it as `sample_idx=sample_idx`, causing a `TypeError` on multimodal training runs. Closes hiyouga#10497 Co-Authored-By: Claude <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the argument name from sample_idx to batch_idx in the call to _slice_mm_inputs_for_sample within src/llamafactory/data/collator.py. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10497
_slice_mm_inputs_for_sample的第 4 个参数名为batch_idx，但第 263 行调用时错用了sample_idx=sample_idx，导致多模态训练在num_sub_seqs <= 1时抛出TypeError。修复：
sample_idx=sample_idx→batch_idx=sample_idxThis contribution was prepared with AI assistance.