Skip to content

fix(mm_plugin): regularize images before processor in MiniCPMV4_6Plugin #10619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZMXJJ wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

fix(mm_plugin): regularize images before processor in MiniCPMV4_6Plugin #10619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/llamafactory/data/mm_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1458,6 +1458,14 @@ def _get_mm_inputs(
mm_inputs = {}

if len(images) != 0:
# Pre-load images into PIL objects so the (torchvision-backed) image_processor passes
# them through unchanged, instead of decoding paths via torchvision (which is built
# without libjpeg on ROCm). See _regularize_images.
images = self._regularize_images(
images,
image_max_pixels=getattr(processor, "image_max_pixels", 1024 * 1024),
image_min_pixels=getattr(processor, "image_min_pixels", 32 * 32),
)["images"]
# The image_processor ignores downsample_mode; target_sizes are always based on patch_size.
# downsample_mode only affects the token divisor in _build_v4_6_placeholder and model forward.
mm_inputs.update(image_processor(images, return_tensors="pt"))
Expand Down