Skip to content

[fix]update license check, update transformers#10632

Merged
frozenleaves merged 5 commits into
hiyouga:mainfrom
frozenleaves:fix-license
Jul 13, 2026
Merged

[fix]update license check, update transformers#10632
frozenleaves merged 5 commits into
hiyouga:mainfrom
frozenleaves:fix-license

Conversation

@frozenleaves

@frozenleaves frozenleaves commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

  1. update license check
  2. update transformers, fix Flash attention broken in transformers 5.6.0 #10610

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the allowed range for the transformers dependency up to 5.13.0 and modifies the license checking script to support a range of valid years (2023-2026). The feedback recommends aligning the runtime dependency check with the exclusions specified in pyproject.toml to avoid known broken versions, and improving the license check logic to robustly handle files that begin with shebang lines.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/llamafactory/extras/misc.py Outdated
Comment thread tests/check_license.py
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@frozenleaves frozenleaves merged commit 8489928 into hiyouga:main Jul 13, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flash attention broken in transformers 5.6.0

1 participant