This repository was archived by the owner on Sep 21, 2025. It is now read-only.
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Implements a new bulk export feature for user data and updates versioning, dependencies, and CI settings.
- Adds a
bulkExportcallable inFirebaseFunctionsServiceand integrates it into the account settings UI with loading states and notifications. - Provides a helper to download the exported JSON and displays alerts during the process.
- Bumps app version to 3.1.0, updates dependencies and pnpm workspace settings, and removes explicit pnpm version pins from GitHub workflows.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/shared/services/firebase-functions/firebase-functions.service.ts | Add _bulkExport callable and bulkExport method |
| src/app/settings/account/account.component.ts | Introduce bulkExport method, loading flag, and download helper |
| src/app/settings/account/account.component.html | Add “Export data” UI section with button and alert |
| src/app/settings/about/about.component.html | Update displayed app version to 3.1.0 |
| pnpm-workspace.yaml | Define onlyBuiltDependencies to optimize builds |
| package.json | Bump version to 3.1.0, update packageManager and dependencies |
| CHANGELOG.md | Add 3.1.0 release entry for export data feature |
| .github/workflows/pull_request.yml | Remove explicit pnpm version pin |
| .github/workflows/deploy.yml | Remove explicit pnpm version pin |
Comments suppressed due to low confidence (3)
src/app/settings/account/account.component.ts:92
- Add unit tests for this
bulkExportmethod to cover loading states, successful downloads, and error handling flows.
public async bulkExport(): Promise<void> {
.github/workflows/pull_request.yml:21
- [nitpick] Pin the pnpm version explicitly (e.g.,
with: version: 10.11.0) to ensure consistent CI installs and avoid surprises when defaults change.
uses: pnpm/action-setup@v4
.github/workflows/deploy.yml:19
- [nitpick] Similarly, consider specifying a pnpm version in this workflow so builds remain reproducible.
uses: pnpm/action-setup@v4
| } | ||
|
|
||
| public async bulkExport(): Promise<any> { | ||
| return await this._bulkExport().catch((error) => { |
There was a problem hiding this comment.
[nitpick] The await on the return is redundant; you can simplify to return this._bulkExport().catch(...) to avoid an extra microtask.
Suggested change
| return await this._bulkExport().catch((error) => { | |
| return this._bulkExport().catch((error) => { |
| ); | ||
| } | ||
|
|
||
| public async bulkExport(): Promise<any> { |
There was a problem hiding this comment.
Consider replacing the Promise<any> return type with a more specific interface for the exported data to improve type safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.