Skip to content

Add noexcept everywhere#42

Merged
hkalbasi merged 1 commit into
mainfrom
push-uoxntwqumzox
May 29, 2025
Merged

Add noexcept everywhere#42
hkalbasi merged 1 commit into
mainfrom
push-uoxntwqumzox

Conversation

@hkalbasi

Copy link
Copy Markdown
Owner

No description provided.

@hkalbasi hkalbasi force-pushed the push-uoxntwqumzox branch 2 times, most recently from 1e6c327 to 06234a3 Compare May 29, 2025 17:15
@hkalbasi hkalbasi requested a review from Copilot May 29, 2025 17:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds noexcept specifiers to various C++ functions and friend declarations in order to enforce non-throwing guarantees. Key changes include:

  • Adding noexcept to function signatures and friend declarations.
  • Introducing a utility (remove_no_except_in_panic) to strip noexcept in panic contexts.
  • Updating multiple template and inline functions in the Rust bridging namespace with noexcept.
Comments suppressed due to low confidence (1)

zngur-generator/src/cpp.rs:1152

  • The runtime check in __zngur_internal_check_init has been commented out, which could allow the use of uninitialized objects without detection. Verify that the removal of this error handling is intentional and that it does not compromise object state safety.
//     ::std::cerr << "Use of uninitialized or moved Zngur Rust object with type {ty}" << ::std::endl;

Comment thread zngur-generator/src/cpp.rs
@hkalbasi hkalbasi force-pushed the push-uoxntwqumzox branch from 06234a3 to 29f9602 Compare May 29, 2025 17:59
@hkalbasi hkalbasi force-pushed the push-uoxntwqumzox branch from 29f9602 to 6467350 Compare May 29, 2025 18:15
@hkalbasi hkalbasi merged commit 708a25a into main May 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants