Add noexcept everywhere#42
Merged
Merged
Conversation
1e6c327 to
06234a3
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds noexcept specifiers to various C++ functions and friend declarations in order to enforce non-throwing guarantees. Key changes include:
- Adding noexcept to function signatures and friend declarations.
- Introducing a utility (remove_no_except_in_panic) to strip noexcept in panic contexts.
- Updating multiple template and inline functions in the Rust bridging namespace with noexcept.
Comments suppressed due to low confidence (1)
zngur-generator/src/cpp.rs:1152
- The runtime check in __zngur_internal_check_init has been commented out, which could allow the use of uninitialized objects without detection. Verify that the removal of this error handling is intentional and that it does not compromise object state safety.
// ::std::cerr << "Use of uninitialized or moved Zngur Rust object with type {ty}" << ::std::endl;
06234a3 to
29f9602
Compare
29f9602 to
6467350
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.