fix: ship 32–256 hicolor icons so Linux launchers resolve Aerion - #396
Open
gianlucamazza wants to merge 2 commits into
Open
fix: ship 32–256 hicolor icons so Linux launchers resolve Aerion#396gianlucamazza wants to merge 2 commits into
gianlucamazza wants to merge 2 commits into
Conversation
Only a 16-bit 256×256 PNG was installed. hicolor marks [256x256/apps] MinSize=64, so launchers that look up ~48px skip it and show no icon (hkdb#395). Commit 8-bit PNGs at 32/48/64/128/256, install all sizes from install.sh / make install-linux, and pack them into the release tarball. Keep the 256 file at the tarball root so AUR aerion-bin stays compatible. Closes hkdb#395
The first commit left Flatpak installing only the 256 PNG — same MinSize=64 miss as the tarball. Install all shipped sizes there too. install.sh now resolves each size via a helper (no else-if), fails if icons/ is present but incomplete, and refreshes the cache under $HICOLOR_DIR. Makefile ICON_SIZES is the documented list for make install-linux / uninstall-linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #395.
Linux packaging installed a single 16-bit 256×256 PNG. The system
hicolortheme marks[256x256/apps]asMinSize=64, so launchers that look up ~48px (Vicinae, and many others with a spec-faithful resolver) skip that directory and show no icon. The.desktopIcon=key was already correct.This ships 8-bit PNGs at 32/48/64/128/256 (from
brand/icon.png) and installs all of them from:build/linux/install.sh(tarball)make install-linuxicons/<size>/plus the 256 file at the root so AURaerion-binstays compatible)CONTRIBUTING.mdsays general PRs are not accepted yet. Opening this so the patch sits on #395; feel free to close and cherry-pick.Validation (Arch Linux)
Isolated
XDG_DATA_HOMEtree produced by the new install loop, GTKIconThemeforced tohicolor(no JARVIS / user-theme overlay):/usr256-only, 16-bit)MinSize=64)…/32x32/…and…/48x48/…Icon=in desktop fileio.github.hkdb.Aerionaerionstill startsbash -noninstall.sh/uninstall.sh. Flatpak YAML parses.Review follow-up (
ac35ecb)install.sh: helper instead ofelse if, fail ificons/exists but a size is missing, cache update uses$HICOLOR_DIR.MakefileICON_SIZESkept in sync with the scripts.