3.5.0 by jkiddo · Pull Request #161 · hl7dk/dk-core

jkiddo · 2025-05-05T13:16:40Z

No description provided.

This reverts commit 946f562.

…nter

* added DkCoreDocumentReference * Update aliases.fsh * Alternative DocRef approach (#158) * Alternative DocRef approach * Further danish constraints * Removed unused alias * update scripts * Update DkCoreDocumentReference.fsh --------- Co-authored-by: Ole Vilstrup <ovi@medcom.dk>

150 profiling of encounter

Added context.sourcePatientInfo only Reference(DkCorePatient)

outcommented context.sourcePatientInfo only Reference(DkCorePatient)

Created short intro page for DocumentReference

…et expansion

Explicit display values for IEEEx73 codes no longer needed

jacand · 2025-11-27T12:35:31Z

input/fsh/DkCorePractitioner.fsh

@@ -8,7 +8,7 @@ Description: "HL7 Denmark core profile for health professionals and other actors
  * ^slicing.rules = #open
  * ^slicing.ordered = false
  * ^slicing.description = "Slice based on the identifier.systemm value which allows for official qualifications to\nDeclaring the slices, and their cardinalities, to allow a KL-code and a SNOMED CT code"


@jkiddo Note that Copilot actually found and fixed a spelling mistake in the change suggestion above that you missed: systemm -> system

input/pagecontent/index.md

input/pagecontent/StructureDefinition-dk-core-encounter-intro.md

Clarify the role of the implementation guide in relation to the FHIR standard and the IPA specification.

…iblity and link to example of diagnosis and ranks.

[(181-review-encounter-example-missing)] More descriptions of respons…

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 7 comments.

input/pagecontent/StructureDefinition-dk-core-encounter-intro.md

input/fsh/valueSets.fsh

input/fsh/DkCoreMinimalDocumentReference.fsh

Copilot · 2025-12-09T09:21:12Z

input/fsh/DkDocumentVersionIDExtension.fsh

+Extension: DkCoreDocumentReferenceVersionID
+Id: dk-core-documentreference-version-id-extension
+Title: "HL7 Denmark core DocumentReference Version ID extension"
+Description: "Extension containing information about the version of the DocumentReference for a specific standard. The version is included in the R5 version of the resource."


The extension is missing context definition. Extensions should define where they can be used via ^context.type and ^context.expression. For a DocumentReference version extension, add:

* ^context.type = http://hl7.org/fhir/extension-context-type#element * ^context.expression = "DocumentReference"

Suggested change

Description: "Extension containing information about the version of the DocumentReference for a specific standard. The version is included in the R5 version of the resource."

Description: "Extension containing information about the version of the DocumentReference for a specific standard. The version is included in the R5 version of the resource."

* ^context.type = http://hl7.org/fhir/extension-context-type#element

* ^context.expression = "DocumentReference"

Copilot · 2025-12-09T09:21:12Z

input/fsh/DkCoreEncounter.fsh

+* extension[0].url = "http://hl7.dk/fhir/core/StructureDefinition/dk-core-planned-start-date"
+* extension[=].valueDateTime = "2025-11-14T09:00:00.0000+01:00"
+* extension[+].url = "http://hl7.dk/fhir/core/StructureDefinition/dk-core-planned-end-date"
+* extension[=].valueDateTime = "2025-11-15"


[nitpick] The planned end date uses a date-only value "2025-11-15" while the planned start date uses a full dateTime "2025-11-14T09:00:00.0000+01:00". For consistency and clarity, consider using the same precision (dateTime format) for both planned dates, especially since the extension is defined as valueDateTime.

Suggested change

* extension[=].valueDateTime = "2025-11-15"

* extension[=].valueDateTime = "2025-11-15T09:00:00.0000+01:00"

input/pagecontent/StructureDefinition-dk-core-encounter-intro.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2025-12-09T10:04:05Z

@jkiddo I've opened a new pull request, #197, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Fix typo: reponsibilities -> responsibilities Co-authored-by: jkiddo <211696+jkiddo@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkiddo <211696+jkiddo@users.noreply.github.com>

jacand

Looks good

RikkeVestesen

Jeg har et enkelt spørgsmål til en dependency

sushi-config.yaml

Fixing #130

Comment out the hl7.fhir.extensions.r5 dependency.

Corrected according to https://terminology.hl7.org/NamingSystem-GLN.html

jkiddo and others added 15 commits March 23, 2025 18:09

Added DocRef based on IHE with backport extension

946f562

Revert "Added DocRef based on IHE with backport extension"

accefe1

This reverts commit 946f562.

[(150-profiling-of-encounter)] First initial draft profiling of Encou…

c8413dc

…nter

[(150-profiling-of-encounter)] First initial draft profiling of Encou…

aabac8d

…nter

[(150-profiling-of-encounter)] First initial draft profiling of Encou…

92cc5d3

…nter

[(150-profiling-of-encounter)] Ready for draft review.

904afb2

[(150-profiling-of-encounter)] Ready for draft review.

17df578

[(150-profiling-of-encounter)] Ready for pull request.

3822fd7

[(150-profiling-of-encounter)] Ready for draft review.

0b482c7

[(150-profiling-of-encounter)] Merge conflict from 3.5.0 handled

1fe956f

[(150-profiling-of-encounter)] Changes after first review

eaa537b

[(150-profiling-of-encounter)] Changes after first review

fe6447f

Merge pull request #164 from hl7dk/150-profiling-of-encounter

e2ac362

150 profiling of encounter

Update DkCoreDocumentReference.fsh

0fd43cc

Added context.sourcePatientInfo only Reference(DkCorePatient)

ovi-medcom force-pushed the 3.5.0 branch from 10ce8eb to 0fd43cc Compare August 25, 2025 10:17

ovi-medcom and others added 7 commits August 25, 2025 12:26

Update DkCoreDocumentReference.fsh

9aa27af

outcommented context.sourcePatientInfo only Reference(DkCorePatient)

Update DkCoreDocumentReference.fsh

c05e410

Create StructureDefinition-dk-core-documentreference-intro.md

ec3d4e4

Created short intro page for DocumentReference

Update StructureDefinition-dk-core-documentreference-intro.md

699bbb3

Issue 155, extra info around IPA use cases

fd993ad

Remove descriptions from SCT codes in valueSets.fsh (#167)

b3e7a0e

Explicit display values for IEEEx73 codes no longer needed for values…

97d003d

…et expansion

jkiddo mentioned this pull request Sep 26, 2025

Removing display values #168

Closed

jkiddo and others added 3 commits September 30, 2025 12:06

Uncomment includeDesignations parameter in IPAProfiles

26760ef

Merge pull request #170 from hl7dk/168-removing-display-values

1bafa3b

Explicit display values for IEEEx73 codes no longer needed

Update SNOMED CT version URL in valueSets.fsh

733e0e1

This was referenced Oct 6, 2025

Profiling of DocumentReference #149

Closed

Add extra information around the use of IPA vs regular core profiles #155

Closed

Fix for #159

13bfc8a

jacand reviewed Nov 27, 2025

View reviewed changes

jkiddo added 3 commits November 28, 2025 08:45

Update StructureDefinition-dk-core-encounter-intro.md

a591aca

Refine description of FHIR standard and IPA specification

1299589

Clarify the role of the implementation guide in relation to the FHIR standard and the IPA specification.

Fix typo in slicing description for qualifications

c50195b

jacand self-requested a review November 28, 2025 17:08

Jesper Langfeldt Hagen Haffgaard and others added 2 commits December 9, 2025 10:08

[(181-review-encounter-example-missing)] More descriptions of respons…

4344f22

…iblity and link to example of diagnosis and ranks.

Merge pull request #196 from hl7dk/181-review-encounter-example-missing

63ae291

[(181-review-encounter-example-missing)] More descriptions of respons…

jkiddo requested a review from Copilot December 9, 2025 09:14

Copilot started reviewing on behalf of jkiddo December 9, 2025 09:14 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

Update input/pagecontent/StructureDefinition-dk-core-encounter-intro.md

c567195

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Dec 9, 2025

Fix typo: reponsibilities → responsibilities #197

Merged

jkiddo marked this pull request as ready for review December 9, 2025 10:43

jacand approved these changes Dec 12, 2025

View reviewed changes

jkiddo requested a review from RikkeVestesen December 12, 2025 12:12

RikkeVestesen approved these changes Dec 15, 2025

View reviewed changes

sushi-config.yaml Outdated Show resolved Hide resolved

jkiddo added 9 commits December 15, 2025 14:56

Update valueSets.fsh

1e677f6

Fixing #130

Update ihe.iti.mhd dependency to version 4.2.3

07bf755

Update FHIR extension dependency version

1802ab8

Update sushi-config.yaml

a8133fd

Update sushi-config.yaml

cabd4c4

Comment out hl7.fhir.extensions.r5 dependency

88746f0

Comment out the hl7.fhir.extensions.r5 dependency.

Uncomment hl7.fhir.extensions.r5 dependency

cec599d

Update GLNIdentifier.fsh

f9426f8

Corrected according to https://terminology.hl7.org/NamingSystem-GLN.html

no message

11d23f0

tmsMedcom approved these changes Dec 16, 2025

View reviewed changes

jkiddo merged commit 8edd300 into master Dec 16, 2025
1 check passed

jkiddo deleted the 3.5.0 branch December 16, 2025 13:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

3.5.0#161

3.5.0#161
jkiddo merged 68 commits intomasterfrom
3.5.0

jkiddo commented May 5, 2025

Uh oh!

jacand Nov 27, 2025

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 9, 2025

Uh oh!

Copilot AI Dec 9, 2025

Uh oh!

Uh oh!

Copilot AI commented Dec 9, 2025

Uh oh!

jacand left a comment

Uh oh!

RikkeVestesen left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

	* extension[=].valueDateTime = "2025-11-15"
	* extension[=].valueDateTime = "2025-11-15T09:00:00.0000+01:00"

Comments

Conversation

jkiddo commented May 5, 2025

Uh oh!

jacand Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Dec 9, 2025

Uh oh!

jacand left a comment

Choose a reason for hiding this comment

Uh oh!

RikkeVestesen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants