fix #439#510
Open
rcarmo wants to merge 2 commits into
Open
Conversation
Owner
|
Hey, thanks for looking into this. Do you also have a clue where that invariant comes from? There shouldn't really be a case where the direction of the entity is not set. The class EntityWalker in walker.py is responsible for constructing the this, possibly the mistake happens in the recursive walker function. |
Author
|
No, but I can look into it further. At least right now this fixes the UX. I have gone down other rabbit holes in the meantime since I really needed to have selections working, but I've been finding some things in the debugger and making sure I can make progress... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the provided sample file for #439, I managed to track it down to providing a "sensible" direction value when there might not be any.