Cgns cpex 41 fix - #123
Merged
Merged
Conversation
CGNS library v.3.4+ API and file format change:
For MIXED and NGON section types:
1. Old cg_elements_read() fails,
2. Introduced new ElementStartOffset array,
3. Introduced new cg_poly_elements_read() function that reads
ElementConnectivity and ElementStartOffset arrays,
4. In new CGNS file format, ElementConnectivity stays the same,
they just added ElementStartOffset array.
… and zonesize array in ReadCGNS.cpp and zone.cpp. 2. Minor refactoring, mostly clang-tidy fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-- Fix for libcgns 3.4+: CPEX 41 NGON modification proposal.
CGNS library v.3.4+ API and file format change:
For MIXED and NGON section types:
ElementConnectivity and ElementStartOffset arrays,
they just added ElementStartOffset array.
-- Also fixed crash when trying to read structural grids.