EnergyCampus-Feature: Add heating grid VIS - #147
Merged
Merged
Conversation
* add interpolation of missing simulation data: add functionality to interpolate of data for nodes not containing data, but a connection to another node: 1. search for nodes data has to be interpolated for 2. loop through these nodes and interpolate data: 2.a get data of next nodes containing data 2.b interpolate data for the current node, based on distance to and data of neighboring nodes * fix shader interpolation error * Refactor osgUtils.cpp --------- Co-authored-by: Marko Djuric <34012023+MDjur@users.noreply.github.com>
aumuell
reviewed
Jul 2, 2026
| // intArray->push_back(i); | ||
| // intArray->push_back(colorInterpolation ? i : 0); | ||
| for (size_t i = 0; i < lengthSegments + 1; ++i) { | ||
| for (size_t j = 0; j <= circleSegments; ++j) { |
Contributor
There was a problem hiding this comment.
Suggested change
| for (size_t j = 0; j <= circleSegments; ++j) { | |
| for (size_t j = 0; j < circleSegments + 1; ++j) { |
This is mean: in both the inner and outer loop, the iteration should include the given upper bound. In order to make clear that both loops should behave the same, their notation should match as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add functionality to interpolate of data for nodes not containing
data, but a connection to another node:
2.a get data of next nodes containing data
2.b interpolate data for the current node, based on distance to and data
of neighboring nodes
fix shader interpolation error
Refactor osgUtils.cpp