Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚫 outdated branch/pr - see #34: Commerce DropIns #3

Closed
wants to merge 66 commits into from

Conversation

sirugh
Copy link
Collaborator

@sirugh sirugh commented Nov 1, 2023

❗ Please see #34 instead of this branch/PR!❗

Description

Drop-in Integration

  • PDP
  • Cart
  • Checkout
  • Order Summary

Pending

  • Remove dead code
  • Drop-in install script @fnhipster
  • Centralized drop-ins initialization file @fnhipster
  • Implement Mini-cart @fnhipster
  • PDP Drop-in Breadcrumbs (use new slot) @alandana
  • Production Backend (Fastly Image Optimization)

Test URLs

Copy link

aem-code-sync bot commented Nov 1, 2023

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Nov 2, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/checkout PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 2, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/checkout PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 3, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/checkout PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 3, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/checkout PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 3, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/checkout PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/products/crown-summit-backpack/24-MB03 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sirugh sirugh changed the title initial: checkout dropin initial: dropins Nov 3, 2023
@sirugh sirugh changed the title initial: dropins initial: Commerce DropIns Nov 3, 2023
Copy link

aem-code-sync bot commented Nov 3, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/checkout PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/products/crown-summit-backpack/24-MB03 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Signed-off-by: sirugh <[email protected]>
Copy link

aem-code-sync bot commented Nov 3, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/checkout PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/products/crown-summit-backpack/24-MB03 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 3, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/checkout PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/products/crown-summit-backpack/24-MB03 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sirugh sirugh marked this pull request as ready for review November 8, 2023 19:43
@sirugh
Copy link
Collaborator Author

sirugh commented Nov 10, 2023

@herzog31 I'm actually going to keep this open until the last minute, I think. We will soon have an order confirmation dropin too. Maybe you could help me get that route defined?

Copy link

aem-code-sync bot commented Nov 13, 2023

1 similar comment
Copy link

aem-code-sync bot commented Nov 13, 2023

Copy link

aem-code-sync bot commented Nov 13, 2023

@hlxsites hlxsites deleted a comment from aem-code-sync bot Jan 26, 2024
@hlxsites hlxsites deleted a comment from aem-code-sync bot Jan 26, 2024
@hlxsites hlxsites deleted a comment from aem-code-sync bot Jan 26, 2024
@hlxsites hlxsites deleted a comment from aem-code-sync bot Jan 26, 2024
@hlxsites hlxsites deleted a comment from aem-code-sync bot Jan 26, 2024
@hlxsites hlxsites deleted a comment from aem-code-sync bot Jan 26, 2024
fnhipster and others added 2 commits January 26, 2024 13:45
* Vendors

* Update install_vendors.sh

* Update .eslintignore

* Update package.json

* trying to clear preview

* Update install_vendors.sh

* centralize initialization

* global intialization vs initialize from block

* Update commerce-order-confirmation.js

* Update .hlxignore

* renamed scripts to __vendors__

* test

* q

* refactor

* Update .eslintignore
@@ -380,3 +362,8 @@ main .section.light,
main .section.highlight {
background-color: var(--color-neutral-500);
}

/* Base Design System Tokens */
.elsie-base-design.elsie-base-design {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add all tokens in :root at the beginning of the file.

@sirugh sirugh closed this Feb 2, 2024
@sirugh
Copy link
Collaborator Author

sirugh commented Feb 2, 2024

Closed PR - please see #34 instead.

We have moved these changes into a fork.

@sirugh sirugh deleted the checkout-dropin branch February 2, 2024 16:10
@sirugh sirugh changed the title 🎁 Commerce DropIns 🚫 outdated branch/pr: Commerce DropIns Feb 2, 2024
@sirugh sirugh changed the title 🚫 outdated branch/pr: Commerce DropIns 🚫 outdated branch/pr - see #34: Commerce DropIns Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants