Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add page view event #47

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Add page view event #47

merged 3 commits into from
Apr 16, 2024

Conversation

herzog31
Copy link

@herzog31 herzog31 commented Apr 11, 2024 •
edited
Loading

  • Add missing page-view event.
  • Minor adjustments to storefrontInstanceContext.
  • Add schema validation for page-view-event, eventForwardingContext and storefrontInstanceContext.
  • Update Events Collector & SDK to latest 1.8.0 version.

Test URLs:

@herzog31 herzog31 added the bug Something isn't working label Apr 11, 2024
@herzog31 herzog31 requested review from dicagno and hannessolo April 11, 2024 11:35
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Apr 11, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Apr 11, 2024 •
edited
Loading

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@herzog31 herzog31 merged commit 60e6882 into main Apr 16, 2024
2 checks passed
@herzog31 herzog31 deleted the page-view branch April 16, 2024 11:08
@herzog31 herzog31 added the changelog Important when updating projects label Jun 6, 2024
dpatil-magento pushed a commit that referenced this pull request Oct 7, 2024
@OscarMerino
Update checkout and order confirmation drop-ins to latest version (#47)
48f8ccf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dicagno dicagno Awaiting requested review from dicagno

@hannessolo hannessolo Awaiting requested review from hannessolo

Assignees
No one assigned
Labels
bug Something isn't working changelog Important when updating projects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@herzog31