fix: split terminal panel into side-by-side Shell/Run and fix run WebSocket (Refs: beans-f4ny)#154
Merged
Merged
Conversation
…Socket (Refs: beans-f4ny) - Fix resolveTerminalWorkDir to strip __run suffix from session IDs before workspace lookup, so run terminal WebSocket connections resolve correctly - Replace Shell/Run tab switcher with horizontal split layout showing both terminals side-by-side when a run process is active - Remove unused terminalTab state variable
- Replace assertion for removed "Shell" tab button with check for two terminal input textboxes (Shell + Run side by side)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveTerminalWorkDirinterminal_handler.godidn't handle the__runsuffix on session IDs. WhenStartRuncreated a session like__central____run, the WebSocket handler couldn't resolve its work directory and immediately closed the connection. Fixed by stripping__runbefore lookup.Test plan
__runsuffix stripping works for worktree IDs too