Skip to content

fix(restyutil): logError → slog.Error per @mliu33; delete unused pkg/model/Employee #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joey0538 merged 1 commit into from
May 8, 2026
+4 −93
Merged

fix(restyutil): logError → slog.Error per @mliu33; delete unused pkg/model/Employee #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 0 additions & 91 deletions pkg/model/employee.go
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion pkg/restyutil/restyutil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func logResponse(_ *resty.Client, resp *resty.Response) error {
}

func logError(req *resty.Request, err error) {
slog.Debug("http error", logFields(req, 0, time.Since(req.Time), err)...)
slog.Error("http error", logFields(req, 0, time.Since(req.Time), err)...)
}

func logFields(req *resty.Request, status int, dur time.Duration, err error) []any {
Expand Down
4 changes: 3 additions & 1 deletion pkg/restyutil/restyutil_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ func TestLog_FiresOnTransportError(t *testing.T) {
c := New("http://"+addr, WithTimeout(500*time.Millisecond))
_, err = c.R().Get("/")
require.Error(t, err)
assert.Contains(t, buf.String(), `"msg":"http error"`)
out := buf.String()
assert.Contains(t, out, `"msg":"http error"`)
assert.Contains(t, out, `"level":"ERROR"`, "transport errors must log at ERROR per codebase convention")
}

type roundTripperFunc func(*http.Request) (*http.Response, error)
Expand Down
Loading