Handle any exception that is not handled by the client application#30
Merged
natrajmolala merged 2 commits intomainfrom Mar 2, 2026
Merged
Handle any exception that is not handled by the client application#30natrajmolala merged 2 commits intomainfrom
natrajmolala merged 2 commits intomainfrom
Conversation
|
|
||
| logger.info("TestErrorTask executing for job: {}", jobData); | ||
|
|
||
| if (jobData.containsKey(ERROR_KEY)) { |
Contributor
There was a problem hiding this comment.
you can simplify this and just throw an exception without the if and also not return..
just these three lines will do
final UUID id = jobData.containsKey(ID_KEY) ? fromString(jobData.getString(ID_KEY)) : randomUUID();
taskStatusService.recordRetryAttempt(id, jobData);
throw new IllegalStateException("Task with retry attempts failed to complete due to unexpected errors!");
|
|
||
| logger.info("TestErrorTask executing for job: {}", jobData); | ||
|
|
||
| if (jobData.containsKey(ERROR_KEY)) { |
maheshsubramanian
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")