Merged
Conversation
srivanimuddineni
requested review from
coling01,
samirgarg and
vineetkapoor-hmcts
vineetkapoor-hmcts
approved these changes
Mar 16, 2026
coling01
reviewed
Mar 16, 2026
| ClientSubscriptionEntity entity = mapper.mapCreateRequestToEntity(request, clockService.nowOffsetUTC()); | ||
| entity = entity.toBuilder().clientId(clientId).build(); | ||
| return mapper.mapEntityToResponse(subscriptionRepository.save(entity)); | ||
| entity = subscriptionRepository.save(entity); |
Collaborator
There was a problem hiding this comment.
we prefer immutable objects ... so think would be better to not have line 40 / 43
- pass clientId into the builder rather than adding it in a second operation
- and get the saved entity back into a new object like 'saved" rather than overwriting the current object.
- pass the hmac into the mapper.mapEntityToResponse(entity) so dont need to do line43 updating the response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hmac object changes