Merged
Conversation
* Add flyway to create tables and fk constraint * Add entities * Add repositories * Add repository tests to prove flyway and jpa line up ok
* Add flyway to create tables and fk constraint * Add entities * Add repositories * Add repository tests to prove flyway and jpa line up ok
* Add flyway to create tables and fk constraint * Add entities * Add repositories * Add repository tests to prove flyway and jpa line up ok
* Add flyway to create tables and fk constraint * Add entities * Add repositories * Add repository tests to prove flyway and jpa line up ok * Add MapStruct mapper layer * Add simple service layer
* Add flyway to create tables and fk constraint * Add entities * Add repositories * Add repository tests to prove flyway and jpa line up ok * Add MapStruct mapper layer * Add simple service layer * Make subscription id a uuid
* Move dockerfiles to root * Bring in api-test.gradle * Config app.yaml and dockerfile to line up for api-test
* Move dockerfiles to root * Bring in api-test.gradle * Config app.yaml and dockerfile to line up for api-test
coling01
commented
Dec 11, 2025
| implementation('uk.gov.hmcts.cp:api-cp-crime-courthearing-cases-results:0.0.0-a65d290') | ||
|
|
||
| // Lets add this to the api because we need it to prevent its openapi NotNull errors | ||
| implementation("io.swagger.core.v3:swagger-annotations:2.2.41") |
Collaborator
Author
There was a problem hiding this comment.
wioll get rid of this next PR when pull in the proper api spec
samirgarg
reviewed
Dec 11, 2025
| tasks.named('build') { | ||
| dependsOn tasks.named('test') | ||
| dependsOn tasks.named('api') | ||
| dependsOn tasks.named('apiTest') |
Contributor
There was a problem hiding this comment.
Do we want to run api tests as part of the build or after the build? Will these api test interact with CP services?
samirgarg
reviewed
Dec 11, 2025
| spring: | ||
| application: | ||
| name: service-hmcts-springboot-demo-postgres | ||
| jpa: |
samirgarg
approved these changes
Dec 11, 2025
Contributor
samirgarg
left a comment
samirgarg
left a comment
There was a problem hiding this comment.
Pending review for all business classes in later MR
madhusudan-yasa
approved these changes
Dec 11, 2025
Contributor
madhusudan-yasa
left a comment
madhusudan-yasa
left a comment
There was a problem hiding this comment.
All initial changes looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.