Notification Changes for AMP-167 & 168(sync) and AMP-169 by srivanimuddineni · Pull Request #31 · hmcts/service-cp-crime-hearing-case-event-subscription

srivanimuddineni · 2026-02-02T17:33:48Z

Notification Changes: covers synchronous implementation of AMP-167 & AMP-168, query api implemenation of AMP-169

API implementation for createNotificationPCR and getPcrDocumentByClientSubscription API
Moved Transactional from Controller to Service layer
Incorporated common retry for material and callback with spring boot retry
Added OpenAPI spec generated client for MaterialAPI
Replaced RestTemplate with RestClient in service + API test. Open api generate spec is not having support for RestClient. Hence left RestTemplate for Material API as is for now.(TBD)

Format fixing

src/main/java/uk/gov/hmcts/cp/subscription/config/RetryConfig.java

src/main/java/uk/gov/hmcts/cp/subscription/controllers/GlobalExceptionHandler.java

src/main/java/uk/gov/hmcts/cp/subscription/config/AppConfig.java

src/main/java/uk/gov/hmcts/cp/subscription/config/MaterialApiConfig.java

src/main/java/uk/gov/hmcts/cp/subscription/config/RetryConfig.java

samirgarg · 2026-02-03T11:51:59Z

@srivanimuddineni can you please squash commits as they are all related to code review incorporation. Ideally a commit history should be a milestone achievement.
See https://github.com/hmcts/api-cp-crime-hearing-case-event-subscription/pull/43/commits
👍 @samirgarg

samirgarg · 2026-02-03T12:00:40Z

Can we please add comment only when the intent is not clear and we deviate from obvious? https://stackoverflow.blog/2021/12/23/best-practices-for-writing-code-comments/
👍 @samirgarg

src/main/java/uk/gov/hmcts/cp/subscription/services/CallbackDeliveryService.java

src/main/java/uk/gov/hmcts/cp/subscription/repositories/SubscriptionRepository.java

src/main/java/uk/gov/hmcts/cp/subscription/services/CallbackDeliveryService.java

src/main/java/uk/gov/hmcts/cp/subscription/services/CallbackService.java

src/main/java/uk/gov/hmcts/cp/subscription/services/DocumentService.java

src/main/java/uk/gov/hmcts/cp/subscription/services/NotificationService.java

src/main/java/uk/gov/hmcts/cp/subscription/services/DocumentService.java

src/test/java/uk/gov/hmcts/cp/subscription/integration/repositories/DocumentRepositoryTest.java

...ov/hmcts/cp/subscription/integration/repositories/SubscriptionRepositoryIntegrationTest.java

src/test/java/uk/gov/hmcts/cp/subscription/integration/IntegrationTestBase.java

src/test/java/uk/gov/hmcts/cp/subscription/unit/controllers/NotificationControllerTest.java

src/test/java/uk/gov/hmcts/cp/subscription/unit/services/NotificationServiceTest.java

src/test/resources/mappings/material-metadata-not-found-mapping.json

src/test/resources/stubs/requests/pcr-request.json

build.gradle

…d few of the review comments

…d few more review comments

src/main/java/uk/gov/hmcts/cp/subscription/controllers/NotificationController.java

…d innecessary UUID issue

…num issue

…mplate

* Add mapper tests * Add service tests ( wip ) * Move callback rest client into client class * reduce number of uuid and enum conversion to string

feature: amp-167 notification changes

…tion access and docuement to ccontroller

…tion access and document to ontroller

.../gov/hmcts/cp/subscription/integration/controllers/NotificationControllerValidationTest.java

…layer for orchestration

Notification Changes

74eb626

srivanimuddineni requested a review from a team as a code owner February 2, 2026 17:33

srivanimuddineni and others added 2 commits February 2, 2026 17:35

Refactor Subscriber class with Lombok annotations

54812a1

Format fixing

Test case fix

3c79368

samirgarg reviewed Feb 2, 2026

View reviewed changes

src/main/java/uk/gov/hmcts/cp/subscription/config/RetryConfig.java Show resolved Hide resolved

samirgarg reviewed Feb 2, 2026

View reviewed changes

src/main/java/uk/gov/hmcts/cp/subscription/controllers/GlobalExceptionHandler.java Show resolved Hide resolved

removed unnecessary comments

8ae9b01

samirgarg reviewed Feb 2, 2026

View reviewed changes

src/main/java/uk/gov/hmcts/cp/subscription/controllers/GlobalExceptionHandler.java Outdated Show resolved Hide resolved

samirgarg reviewed Feb 2, 2026

View reviewed changes

src/main/java/uk/gov/hmcts/cp/subscription/controllers/GlobalExceptionHandler.java Outdated Show resolved Hide resolved

srivanimuddineni added 3 commits February 2, 2026 18:08

Resolved review comments

2f6baa4

Reverted docker file to original

5315962

pmd issues fix

f8e4490

srivanimuddineni requested a review from coling01 February 2, 2026 18:55

samirgarg reviewed Feb 3, 2026

View reviewed changes

src/main/java/uk/gov/hmcts/cp/subscription/config/AppConfig.java Show resolved Hide resolved

samirgarg reviewed Feb 3, 2026

View reviewed changes

src/main/java/uk/gov/hmcts/cp/subscription/config/MaterialApiConfig.java Show resolved Hide resolved

samirgarg reviewed Feb 3, 2026

View reviewed changes

src/main/java/uk/gov/hmcts/cp/subscription/config/RetryConfig.java Show resolved Hide resolved