Merged
Conversation
coling01
reviewed
Feb 9, 2026
.../gov/hmcts/cp/subscription/integration/controllers/SubscriptionControllerValidationTest.java
Show resolved
Hide resolved
coling01
reviewed
Feb 9, 2026
...gov/hmcts/cp/subscription/integration/controllers/NotificationControllerIntegrationTest.java
Outdated
Show resolved
Hide resolved
coling01
reviewed
Feb 9, 2026
.../gov/hmcts/cp/subscription/integration/controllers/SubscriptionControllerValidationTest.java
Outdated
Show resolved
Hide resolved
coling01
reviewed
Feb 9, 2026
.../gov/hmcts/cp/subscription/integration/controllers/SubscriptionControllerValidationTest.java
Show resolved
Hide resolved
coling01
reviewed
Feb 9, 2026
src/test/java/uk/gov/hmcts/cp/subscription/services/CallbackDeliveryServiceTest.java
Show resolved
Hide resolved
coling01
reviewed
Feb 9, 2026
src/test/java/uk/gov/hmcts/cp/subscription/services/CallbackDeliveryServiceTest.java
Outdated
Show resolved
Hide resolved
coling01
approved these changes
Feb 9, 2026
Collaborator
coling01
left a comment
coling01
left a comment
There was a problem hiding this comment.
Looks great, few comments but happy to merge ... onwards and upwards !
Pull the creation of Notification payload into a Mapper class This allows us to a) Add a strong / simple mapper test to easily confirm that all fields are set b) greatly simplify the service test to just use simple objects
Pull the creation of Notification payload into a Mapper class This allows us to a) Add a strong / simple mapper test to easily confirm that all fields are set b) greatly simplify the service test to just use simple objects
Pull the creation of Notification payload into a Mapper class This allows us to a) Add a strong / simple mapper test to easily confirm that all fields are set b) greatly simplify the service test to just use simple objects
Dev/amp 256 colin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes:
Subscription API : Callback URL moved from query param into body (ClientSubscriptionRequest).
PCR callback payload: Switched from PcrOutboundPayload to EventNotificationPayload (API model), with caseUrn replaced by cases array.
CallbackDeliveryService: Builds EventNotificationPayload from PcrEventPayload
NotificationController – Updated getPcrDocumentByClientSubscription to match NotificationApi.
NotificationControllerIntegrationTest – Added test case for conditiontimeout with shorter retry settings for quicker runs.