AMP-313: Use centralized deploy workflow from cp-vp-aks-deploy#81
Open
AMP-313: Use centralized deploy workflow from cp-vp-aks-deploy#81
Conversation
There was a problem hiding this comment.
Pull request overview
Centralizes Kubernetes deployment by delegating the “update service tag” step to the hmcts/cp-vp-aks-deploy reusable workflow, replacing the prior inline deploy logic and adding an explicit wait for the ADO pipeline run to complete before deploying.
Changes:
- Pass a new deploy key secret (
CP_VP_AKS_DEPLOY_KEY) and adeploy_environmentinput through the calling workflows. - Update the ADO deploy trigger step to capture the pipeline
run_id, then add a monitoring job to wait for completion. - Add a
Deploy-To-K8sjob that calls the centralized reusable workflow inhmcts/cp-vp-aks-deploy.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/ci-released.yml | Passes the new deploy key secret and deploy_environment into the reusable CI workflow for release runs. |
| .github/workflows/ci-draft.yml | Passes the new deploy key secret and deploy_environment into the reusable CI workflow for non-release runs. |
| .github/workflows/ci-build-publish.yml | Adds required deploy key secret + deploy environment input; introduces ADO run monitoring and delegates K8s deploy to the centralized reusable workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add Wait-For-ACR-Push, Update-Deploy-Config, and Trigger-K8s-Deploy jobs to ci-build-publish.yml. Upgrade trigger-ado-pipeline to v2 to capture run_id. Add deploy_environment input for configurability.
Trozz
force-pushed
the
AMP-313/auto-deploy-pipeline
branch
from
4f0a198 to
9005523
Compare
samirgarg
reviewed
Mar 13, 2026
| Deploy-To-K8s: | ||
| needs: [Wait-For-ACR-Push, Artefact-Version, Build] | ||
| if: ${{ inputs.trigger_deploy }} | ||
| uses: hmcts/cp-vp-aks-deploy/.github/workflows/update-service-tag.yml@main |
Contributor
There was a problem hiding this comment.
this entry looks odd for the path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
See AMP-313
Change description
Replace
Update-Deploy-ConfigandTrigger-K8s-Deployjobs with a singleDeploy-To-K8sreusable workflow call tocp-vp-aks-deploy. Deployment logic is now centralized, reducing ~96 lines to 8.Depends on https://github.com/hmcts/cp-vp-aks-deploy/pull/24 being merged first.
Does this PR introduce a breaking change? (check one with "x")