AMP-313: Use centralized deploy workflow from cp-vp-aks-deploy#160
AMP-313: Use centralized deploy workflow from cp-vp-aks-deploy#160
Conversation
Add Wait-For-ACR-Push, Update-Deploy-Config, and Trigger-K8s-Deploy jobs to automate the full deployment flow after ADO pipeline 460 completes. Updates trigger-ado-pipeline to v2 to capture run_id.
There was a problem hiding this comment.
Pull request overview
This PR extends the repo’s reusable GitHub Actions build/publish workflow to automatically progress from an Azure DevOps build (pipeline 460) into updating a separate deployment-config repo and then triggering a Kubernetes deployment (pipeline 434).
Changes:
- Adds a
deploy_environmentinput plumbed through draft/release workflows. - Updates ADO trigger step to
hmcts/trigger-ado-pipeline@v2and capturesrun_idfor downstream monitoring. - Introduces new jobs to wait for the ADO run to finish, update
hmcts/cp-vp-aks-deployvia SSH, and trigger the K8s deployment pipeline.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/ci-released.yml |
Passes deploy_environment into the reusable workflow for release runs. |
.github/workflows/ci-draft.yml |
Passes deploy_environment into the reusable workflow for non-release runs. |
.github/workflows/ci-build-publish.yml |
Adds deployment automation jobs, new secret/input, and updates the ADO trigger action to v2 with run monitoring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fi | ||
|
|
||
| - name: Install yq | ||
| uses: mikefarah/yq@v4.44.1 |
There was a problem hiding this comment.
The Install yq step is malformed and likely won’t make yq available to the following run step. The uses: line is mis-indented (YAML syntax error), and mikefarah/yq is typically a Docker/composite action that runs yq within that step rather than installing it for later. Fix the indentation and either install the yq binary on the runner (so yq eval ... works), or run the yq command via the action’s supported inputs in the same step.
| uses: mikefarah/yq@v4.44.1 | |
| run: | | |
| YQ_VERSION=v4.44.1 | |
| YQ_BINARY=yq_linux_amd64 | |
| wget "https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/${YQ_BINARY}" -O /tmp/yq | |
| sudo mv /tmp/yq /usr/local/bin/yq | |
| sudo chmod +x /usr/local/bin/yq |
Trozz
changed the title
JIRA link (if applicable)
See AMP-313
Change description
Replace
Update-Deploy-ConfigandTrigger-K8s-Deployjobs with a singleDeploy-To-K8sreusable workflow call tocp-vp-aks-deploy. Deployment logic is now centralized, reducing ~98 lines to 8.Depends on https://github.com/hmcts/cp-vp-aks-deploy/pull/24 being merged first.
Does this PR introduce a breaking change? (check one with "x")