Skip to content

Dev/connection impl #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yashyashm merged 12 commits into from
Aug 13, 2025
Merged

Dev/connection impl #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
de66a7f
added code to test the connectvity
yashyashm Jul 28, 2025
8cb8a73
Replace the url with actual url and implemented other functionlity
yashyashm Aug 7, 2025
478f52f
Merge remote-tracking branch 'origin/main' into dev/connection-impl
yashyashm Aug 7, 2025
10c3e77
merge from main
yashyashm Aug 7, 2025
dd2a67f
update caseurnmapper to urnmapper
yashyashm Aug 7, 2025
7331493
update caseurnmapper to urnmapper
yashyashm Aug 7, 2025
05a5341
update caseurnmapper to urnmapper
yashyashm Aug 7, 2025
316a6e4
update caseurnmapper to urnmapper
dalgazinhmcts Aug 8, 2025
d83ebf4
update pact flow test
yashyashm Aug 8, 2025
94ec087
updated code for pact testing
yashyashm Aug 12, 2025
dca7a26
added logs
yashyashm Aug 13, 2025
f5d0c6d
Merge branch 'main' into dev/connection-impl
yashyashm Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,13 +268,13 @@ dependencies {
implementation 'org.hibernate.validator:hibernate-validator:9.0.1.Final'
implementation 'org.apache.commons:commons-text:1.13.1'

implementation 'com.fasterxml.jackson.core:jackson-databind:2.19.2'
implementation 'com.fasterxml.jackson.core:jackson-databind:2.19.1'
// implementation 'com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.15.2'

compileOnly group: 'org.projectlombok', name: 'lombok', version: lombokVersion
annotationProcessor group: 'org.projectlombok', name: 'lombok', version: lombokVersion

testImplementation(platform('org.junit:junit-bom:5.13.4'))
testImplementation(platform('org.junit:junit-bom:5.13.3'))
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine'
testImplementation group: 'org.springframework.boot', name: 'spring-boot-starter-test', version: '3.5.3', {
exclude group: 'junit', module: 'junit'
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/uk/gov/hmcts/cp/services/CaseUrnMapperService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,16 @@
public String getCaseId(final String caseUrn) {
try {
ignoreCertificates();
ResponseEntity<CaseMapperResponse> responseEntity = restTemplate.exchange(

Check warning on line 33 in src/main/java/uk/gov/hmcts/cp/services/CaseUrnMapperService.java

View workflow job for this annotation

GitHub Actions / pmd-analysis

Local variable 'responseEntity' could be declared final 

A local variable assigned only once can be declared final.

LocalVariableCouldBeFinal (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#localvariablecouldbefinal
getCaseIdUrl(caseUrn),
HttpMethod.GET,
getRequestEntity(),
CaseMapperResponse.class
);
LOG.info("CaseMapperResponse is : {} and body : {} caseurn : {} ", responseEntity.getStatusCode(), responseEntity.getBody(), caseUrn);

Check failure on line 39 in src/main/java/uk/gov/hmcts/cp/services/CaseUrnMapperService.java

View workflow job for this annotation

GitHub Actions / pmd-analysis

Logger calls should be surrounded by log level guards. 

Whenever using a log level, one should check if it is actually enabled, or
otherwise skip the associate String creation and manipulation, as well as any method calls.

An alternative to checking the log level are substituting parameters, formatters or lazy logging
with lambdas. The available alternatives depend on the actual logging framework.

GuardLogStatement (Priority: 2, Ruleset: Best Practices)
https://docs.pmd-code.org/snapshot/pmd_rules_java_bestpractices.html#guardlogstatement

if (responseEntity.getStatusCode().is2xxSuccessful() && responseEntity.getBody() != null) {
CaseMapperResponse body = responseEntity.getBody();

Check warning on line 42 in src/main/java/uk/gov/hmcts/cp/services/CaseUrnMapperService.java

View workflow job for this annotation

GitHub Actions / pmd-analysis

Local variable 'body' could be declared final 

A local variable assigned only once can be declared final.

LocalVariableCouldBeFinal (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#localvariablecouldbefinal
return body.getCaseId();
}
} catch (Exception e) {
Expand All @@ -48,13 +50,14 @@

public String getCaseMapperServiceUrl() {
if (this.caseMapperServiceUrl != null) {
LOG.info("caseMapperServiceUrl is : {}", this.caseMapperServiceUrl);
return this.caseMapperServiceUrl;

Check warning on line 54 in src/main/java/uk/gov/hmcts/cp/services/CaseUrnMapperService.java

View workflow job for this annotation

GitHub Actions / pmd-analysis

A method should have only one exit point, and that should be the last statement in the method 

A method should have only one exit point, and that should be the last statement in the method.

OnlyOneReturn (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#onlyonereturn
}
LOG.atError().log("caseMapperServiceUrl is empty");
return "https://devcp01.ingress01.dev.nl.cjscp.org.uk/urnmapper";
}

private String getCaseIdUrl(String caseUrn) {

Check warning on line 60 in src/main/java/uk/gov/hmcts/cp/services/CaseUrnMapperService.java

View workflow job for this annotation

GitHub Actions / pmd-analysis

Parameter 'caseUrn' is not assigned and could be declared final 

Reports method and constructor parameters that can be made final because they are never reassigned within the body of the method.

This rule ignores unused parameters so as not to overlap with the rule {% rule java/bestpractices/UnusedFormalParameter %}.
It will also ignore the parameters of abstract methods.

MethodArgumentCouldBeFinal (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#methodargumentcouldbefinal
LOG.atDebug().log("Fetching case id for case urn: {}", caseUrn);
return UriComponentsBuilder
.fromUriString(getCaseMapperServiceUrl())
Expand All @@ -64,7 +67,7 @@
}

private HttpEntity<String> getRequestEntity() {
HttpHeaders headers = new HttpHeaders();

Check warning on line 70 in src/main/java/uk/gov/hmcts/cp/services/CaseUrnMapperService.java

View workflow job for this annotation

GitHub Actions / pmd-analysis

Local variable 'headers' could be declared final 

A local variable assigned only once can be declared final.

LocalVariableCouldBeFinal (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#localvariablecouldbefinal
headers.set("Accept", MediaType.APPLICATION_JSON_VALUE);
return new HttpEntity<>(headers);
}
Expand Down
Loading