SSCSFT-88 Other party details not included in the body of the notice

[alibaseit]

Jira link

See SSCSFT-88

Change description

This change introduces:

1. Adding Other party details to notices

Testing done

Security Vulnerability Assessment

CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?

• Yes
• No

Checklist

• commit messages are meaningful and follow good commit message guidelines
• README and other documentation has been updated / added (if needed)
• tests have been updated / new tests has been added (if needed)
• Does this PR introduce a breaking change

[github-actions]

CCD diff report

No change

[github-actions]

Integration Tests results

   84 files  ± 0     84 suites  ±0   10m 39s ⏱️ -38s
1 523 tests +16  1 515 ✅ +16  8 💤 ±0  0 ❌ ±0 
1 526 runs  +16  1 518 ✅ +16  8 💤 ±0  0 ❌ ±0 

Results for commit 14c4a59. ± Comparison against base commit 15d1e8c.

This pull request removes 10 and adds 26 tests. Note that renamed tests count towards both.

uk.gov.hmcts.reform.sscs.bulkscan.controllers.SscsBulkScanExceptionRecordCallback ‑ [1] url=http://localhost:32953/transform-exception-record/, isAuto=false
uk.gov.hmcts.reform.sscs.bulkscan.controllers.SscsBulkScanExceptionRecordCallback ‑ [2] url=http://localhost:32953/transform-scanned-data/, isAuto=true
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ notConsideredNoAward_shouldGeneratePdfWithExpectedTextForHearingType(faceToFace, true, false) [18]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ notConsideredNoAward_shouldGeneratePdfWithExpectedTextForHearingType(faceToFace, true, true) [19]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ notConsideredNoAward_shouldGeneratePdfWithExpectedTextForHearingType(telephone, true, false) [10]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ notConsideredNoAward_shouldGeneratePdfWithExpectedTextForHearingType(telephone, true, true) [11]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ notConsideredNoAward_shouldGeneratePdfWithExpectedTextForHearingType(video, true, false) [0]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ notConsideredNoAward_shouldGeneratePdfWithExpectedTextForHearingType(video, true, false) [2]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ notConsideredNoAward_shouldGeneratePdfWithExpectedTextForHearingType(video, true, true) [1]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ notConsideredNoAward_shouldGeneratePdfWithExpectedTextForHearingType(video, true, true) [3]

uk.gov.hmcts.reform.sscs.bulkscan.controllers.SscsBulkScanExceptionRecordCallback ‑ [1] url=http://localhost:33301/transform-exception-record/, isAuto=false
uk.gov.hmcts.reform.sscs.bulkscan.controllers.SscsBulkScanExceptionRecordCallback ‑ [2] url=http://localhost:33301/transform-scanned-data/, isAuto=true
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ nonDescriptorFlow_shouldGeneratePdfWithExpectedTextWithOtherParties(false) [0]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ nonDescriptorFlow_shouldGeneratePdfWithExpectedTextWithOtherParties(true) [1]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ nonDescriptorFlow_shouldGeneratePdfWithExpectedTextWithTenOtherPartiesAttended(false) [0]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ nonDescriptorFlow_shouldGeneratePdfWithExpectedTextWithTenOtherPartiesAttended(true) [1]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ nonDescriptorFlow_shouldGeneratePdfWithExpectedTextWithTenOtherPartiesDidNotAttend(false) [0]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ nonDescriptorFlow_shouldGeneratePdfWithExpectedTextWithTenOtherPartiesDidNotAttend(true) [1]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ notConsideredEnhancedRate_shouldGeneratePdfWithExpectedText(higher, true, true, false) [1]
uk.gov.hmcts.reform.sscs.callback.PipWriteFinalDecisionIt ‑ notConsideredEnhancedRate_shouldGeneratePdfWithExpectedText(higher, true, true, true) [3]
…

♻️ This comment has been updated with latest results.

[raghera]

Thanks Ali, seems like the tests were very difficult to update.

Not easy to code review all the tests so mostly focused on your logic. Seems like we need to be very thorough in QA testing as this is something that Judges will see and there's limited A/Cs. I will leave a comment for the QAs.

[raghera]

All comments addressed so approved Ali!

I think the testing is really important on this one and I have made a note of that for QA. Class needs refactoring but that is outside the scope of this work.