SSCSCI-2354: Fix isScottishCase not being set for bulk scan cases#5115
Open
alext-justice wants to merge 5 commits intomasterfrom
Open
SSCSCI-2354: Fix isScottishCase not being set for bulk scan cases#5115alext-justice wants to merge 5 commits intomasterfrom
alext-justice wants to merge 5 commits intomasterfrom
Conversation
- Add isScottishCase to SscsCaseValidator when RPC is set for paper/bulk scan cases - Add backfill logic to CaseUpdatedAboutToSubmitHandler to set isScottishCase if empty - Add tests for both fixes Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
CCD diff reportNo change |
Integration Tests results 84 files ±0 84 suites ±0 11m 43s ⏱️ +26s Results for commit bd4bfe8. ± Comparison against base commit 15d1e8c. This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isScottishCasetoSscsCaseValidatorwhen RPC is set for paper/bulk scan casesCaseUpdatedAboutToSubmitHandlerto setisScottishCaseif empty when cases are updatedProblem
Scottish cases created via bulk scan/paper appeals were not getting
isScottishCaseset because:CreateCaseAboutToSubmitHandlerexcludes paper cases (receivedVia == "Paper")SscsCaseValidatorsetsregionalProcessingCenterbut notisScottishCaseThis resulted in only 3 out of 72 Glasgow cases having the
isScottishCaseflag set correctly.Solution
isScottishCaseinSscsCaseValidatorwhen RPC is determined for bulk scan casesmaybeChangeIsScottishto also set the flag when it's empty (not just when RPC changes), so existing cases get backfilled on next updateTest plan
SscsCaseValidator- Glasgow and non-Glasgow postcodesCaseUpdatedAboutToSubmitHandler- backfill scenario🤖 Generated with Claude Code