Fix Challenge 2 in Section 2.3: Use "positive integers" instead of "integers" for monoid under multiplication #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
How does it break the unit law? |
Contributor
Author
|
As you correctly pointed out, the set of all integers forms a monoid under multiplication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates Challenge 2 in Section 2.3 (Free Monoids) by replacing "integers" with "positive integers" for the following reason:
The set of all integers (which includes 0) is not a monoid under multiplication.
While 1 serves as an identity element, the presence of 0 breaks the unit law.
To form a valid monoid under multiplication, we must exclude 0. The set of positive integers satisfies the monoid laws with multiplication as the binary operation and 1 as the identity.