Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates deck & luma versions (also change to listed allowed react versions, vague on this and maybe it should be separate).
Fixes #854 (somewhat redundantly as another PR already does this, not sure why that wasn't merged).
Background
Trying to keep up-to-date with these (in particular, I think they changed something so that gl context is made with
preserveDrawingBuffer
which I need, and I couldn't seem to get the right option passed through with 9.0)Change List
"@deck.gl/*": "~9.1.11"
"@luma.gl/*": "~9.1.9"
"react"
to include|| ^ 19.0.0
(not meaningfully tested)pnpm i
stopped complaining)import { createTestContext } from '@luma.gl/test-utils';
in layers test utils, as the resulting device wasn't actually being used and this import no longer existsChecklist
Not tested with a large number of different files so far, but seems ok.
Automated tests pass (although for some reason I thought it was hanging at some point and now I don't know why it behaves any differently).