Skip to content

Update deck & luma 9.1 #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

xinaesthete
Copy link
Contributor

Updates deck & luma versions (also change to listed allowed react versions, vague on this and maybe it should be separate).

Fixes #854 (somewhat redundantly as another PR already does this, not sure why that wasn't merged).

Background

Trying to keep up-to-date with these (in particular, I think they changed something so that gl context is made with preserveDrawingBuffer which I need, and I couldn't seem to get the right option passed through with 9.0)

Change List

  • "@deck.gl/*": "~9.1.11"
  • "@luma.gl/*": "~9.1.9"
  • "react" to include || ^ 19.0.0 (not meaningfully tested)
  • "@probe.gl/test-utils": "^4.1.0-alpha.2" (dubious about changing to an alpha, just changed things until pnpm i stopped complaining)
  • remove import { createTestContext } from '@luma.gl/test-utils'; in layers test utils, as the resulting device wasn't actually being used and this import no longer exists

Checklist

  • Update JSdoc types if there is any API change. (n/a)
  • Make sure Avivator works as expected with your change.

Not tested with a large number of different files so far, but seems ok.

Automated tests pass (although for some reason I thought it was hanging at some point and now I don't know why it behaves any differently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong parameter for renderPass in @luma.gl model.draw()
1 participant