Implement logarithmic flag for single slider widgets#2415
Open
SamuMazzi wants to merge 2 commits intohoffstadt:masterfrom
Open
Implement logarithmic flag for single slider widgets#2415SamuMazzi wants to merge 2 commits intohoffstadt:masterfrom
logarithmic flag for single slider widgets#2415SamuMazzi wants to merge 2 commits intohoffstadt:masterfrom
Conversation
Also, use generics with those config structs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements
logarithmicflag for theint/double/float_slider. This is done by refactoring a little bit the underlying structs.I also removed
verticalvariable and used the flagImGuiSliderFlags_Vertical, for coherence.Also a little refactor regarding this PR has been done in
mvBasicWidgets.cpp.pre_drawandpost_drawparts were all the same (and sometimes with some typos) so I just wrapped them in two functions.I think this are all changes to the codebase that are not essential, they are simple and I think they improve code quality, but I'd like a feedback on this.
Close #2404