fix: Restored item aliases in node editor and other places #2122#2615
Open
v-ein wants to merge 1 commit intohoffstadt:masterfrom
Open
fix: Restored item aliases in node editor and other places #2122#2615v-ein wants to merge 1 commit intohoffstadt:masterfrom
v-ein wants to merge 1 commit intohoffstadt:masterfrom
Conversation
…2122 This fixes a regression introduced in hoffstadt#2034. Also, generate_uuid() now does not perform useless item lookup (GetItem()). Overall, the use of ToPyUUID() has been revisited and somewhat cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: fix: Restored item aliases in node editor and other places #2122
assignees: @hoffstadt
Description:
Closes #2122.
This PR fixes a regression introduced in #2034. Now, if an item has an alias, its alias is used by DPG in callbacks and other places instead of its numeric UUID, like it was in 1.8 and before.
Also,
generate_uuid()now does not perform useless item lookup (GetItem()). Overall, the use ofToPyUUID()has been revisited and somewhat cleaned up.The code can be improved/cleaned up further by making various pieces return UUID of 0 if the corresponding item has been deleted, but this would break the old behavior (even though it's unlikely that anyone would notice). Currently, functions like
get_active_windowreturn a nonzero UUID even if it does not exist anymore. I've chosen to keep this old behavior for now. We can always break things later 😂.Concerning Areas:
None.