PyObject leaks in custom series and other places#2617
Open
v-ein wants to merge 2 commits intohoffstadt:masterfrom
Open
PyObject leaks in custom series and other places#2617v-ein wants to merge 2 commits intohoffstadt:masterfrom
v-ein wants to merge 2 commits intohoffstadt:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: PyObject leaks in custom series and other places
assignees: @hoffstadt
Description:
Closes #2104.
PyDict_SetItemStringdoes not steal the reference to the value passed in, and we therefore mustDECREFit on our own. This PR corrects all thePyDict_SetItemStringcalls and fixes the associated object leaks.Concerning Areas:
None.