Master #16
Open
Master #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on serialzation and consumption to handlers, add metrics
This is defined in twittertypes.go Other 'id' types are int64, so maybe this is an oversight? This caused the error 'json: cannot unmarshal number into Go value of type string' when unmarshalling JSON returned by the Twitter REST API. The error was fixed by changing the type. BTW, twitter also returns a 'in_reply_to_status_id_str' value if a string is needed, although this value is not set in this file.
Tweet.In_reply_to_status_id type is string and should be int64.
…ter to get rid of deletes
Fix nullable types
Additional parameter to add location support.
Adding locations as parameter to filter (breaking api change)
move to new oauth lib
Fix data race detected by go's race detector
Add Lang to Tweet type
Ran across this problem when running another project's test suite with -race.
Lock all of Close instead of just conn.stale
…etting a connection without response
implement support for insecure https connections, return error when getting a connection without response
Add timeouts on TLSHandshake and ResponseHeader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock all of Close instead of just conn.stale