Skip to content

Project Analytics Refactor #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Project Analytics Refactor #6

wants to merge 1 commit into from

Conversation

@kespinola
Copy link

@kespinola kespinola commented Sep 12, 2023

Change

  • Remove DataPoint and DataPoints that handles returning a collection of analytics points. Replace with dedicated GraphQL field resolvers.
  • Create dedicated datapoints for mints and customers defining deserializers.
  • Refactor query client return Vec where T is resource specific data point.

@kespinola
refactor: cube response deserialization and graphql objects for proje…
aeb006d 
…cts. stub out organizations and collections for the time being.
@mpwsh mpwsh self-requested a review September 12, 2023 14:19
kespinola
kespinola commented Sep 12, 2023
View reviewed changes
app/Cargo.toml
async-graphql-poem = "5.0.3"
serde = { version = "1.0.152", features = ["derive"] }
serde = { version = "1.0.188", features = ["derive"] }
serde_derive = { version = "1.0.188" }
Copy link
Author

@kespinola kespinola Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpwsh mpwsh Awaiting requested review from mpwsh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kespinola