docs: view new leave policy#109
Conversation
WalkthroughDocumentation update to the leave policy establishing a service-time-based paid days table, introducing an accrual formula for gradual day accumulation, and changing carry-over rules from a 3-day maximum to full carry-over with 6-month expiration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Time Submission Status
You can submit time with the command. Example: See available commands to help comply with our Guidelines. |
|
@holdex pr submit-time 30m |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/LEAVE_POLICY.md`:
- Around line 35-43: The formula paidLeaveAmount = (totalEligibleLeaves / 365) ×
daysElapsed yields fractional leave; update the policy to specify the
rounding/precision rule for paidLeaveAmount (e.g., round to nearest half-day,
round down to nearest 0.25 day, or store as two-decimal-place hours) and state
whether intermediate calculations use exact decimals or a fixed precision;
reference the symbols paidLeaveAmount, totalEligibleLeaves, and daysElapsed and
add the rule immediately after the formula so payroll and leave balances apply
the same rounding consistently.
- Around line 35-37: Add a language label to the fenced code block containing
the expression "paidLeaveAmount = (totalEligibleLeaves / 365) × daysElapsed" so
markdownlint MD040 is satisfied; edit the triple backticks before that line to
include a language such as text (e.g., change ``` to ```text) leaving the code
content unchanged.
- Around line 17-18: The two eligibility tiers "0 – 6 months" and "6 months – 1
year" overlap at exactly 6 months; resolve this by making one side
exclusive—e.g., change the first tier label "0 – 6 months" to "0 – <6 months"
(or "0 – up to 5 months 30 days") so that the second tier "6 months – 1 year"
clearly applies at the 6-month mark; update the table entry containing "0 – 6
months" accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 42d29f83-ddc6-4d18-9d0f-c740e0f50b68
📒 Files selected for processing (1)
docs/LEAVE_POLICY.md
|
@zolotokrylin you can submit your time here |
|
@holdex pr submit-time 25m |
resolves: https://github.com/holdex/wizard/issues/1324
Summary by CodeRabbit