Skip to content

docs: view new leave policy#109

Merged
zolotokrylin merged 3 commits intomainfrom
docs/leave
Apr 30, 2026
Merged

docs: view new leave policy#109
zolotokrylin merged 3 commits intomainfrom
docs/leave

Conversation

@williamrusdyputra
Copy link
Copy Markdown
Contributor

@williamrusdyputra williamrusdyputra commented Apr 30, 2026

resolves: https://github.com/holdex/wizard/issues/1324

Summary by CodeRabbit

  • Documentation
    • Updated leave policy with new service-time-based paid day entitlements (varying by tenure)
    • Added clarification on how annual entitlements are granted and accrued gradually throughout the leave year
    • Changed carry-over policy to allow full carry-over of unused paid days, expiring 6 months into the new year

@williamrusdyputra williamrusdyputra self-assigned this Apr 30, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

Walkthrough

Documentation update to the leave policy establishing a service-time-based paid days table, introducing an accrual formula for gradual day accumulation, and changing carry-over rules from a 3-day maximum to full carry-over with 6-month expiration.

Changes

Cohort / File(s) Summary
Leave Policy Documentation
docs/LEAVE_POLICY.md
Replaced entitlement/carry/payout matrix with service-time-based table; added accrual model formula; changed carry-over from max 3 days to full carry-over expiring 6 months into new year; clarified annual entitlements and simplified section headings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • markholdex
  • zolotokrylin
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'docs: view new leave policy' is vague and doesn't clearly describe the main change (updating leave policy with new accrual model and carry-over rules). Use a more specific title like 'docs: update leave policy with service-time accrual model and carry-over rules' to clearly convey the primary change.
Linked Issues check ❓ Inconclusive The PR addresses the core issue by introducing a new service-time-based paid-days table and carry-over rules, but doesn't directly solve the leave year timing problem raised in issue #1324. Clarify how the new policy handles employees with non-standard leave year resets (e.g., August reset) to fully resolve the timing issue described in #1324.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Out of Scope Changes check ✅ Passed All changes in LEAVE_POLICY.md are directly related to the leave policy update and linked issue; no out-of-scope modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/leave

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@williamrusdyputra williamrusdyputra marked this pull request as ready for review April 30, 2026 03:00
@holdex
Copy link
Copy Markdown

holdex Bot commented Apr 30, 2026

Time Submission Status

Member Status Time Action Last Update
williamrusdyputra ✅ Submitted 30min Update time Apr 30, 2026, 3:53 AM
zolotokrylin ✅ Submitted 25min Update time Apr 30, 2026, 3:53 AM

You can submit time with the command. Example:

@holdex pr submit-time 15m

See available commands to help comply with our Guidelines.

@williamrusdyputra
Copy link
Copy Markdown
Contributor Author

@holdex pr submit-time 30m

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/LEAVE_POLICY.md`:
- Around line 35-43: The formula paidLeaveAmount = (totalEligibleLeaves / 365) ×
daysElapsed yields fractional leave; update the policy to specify the
rounding/precision rule for paidLeaveAmount (e.g., round to nearest half-day,
round down to nearest 0.25 day, or store as two-decimal-place hours) and state
whether intermediate calculations use exact decimals or a fixed precision;
reference the symbols paidLeaveAmount, totalEligibleLeaves, and daysElapsed and
add the rule immediately after the formula so payroll and leave balances apply
the same rounding consistently.
- Around line 35-37: Add a language label to the fenced code block containing
the expression "paidLeaveAmount = (totalEligibleLeaves / 365) × daysElapsed" so
markdownlint MD040 is satisfied; edit the triple backticks before that line to
include a language such as text (e.g., change ``` to ```text) leaving the code
content unchanged.
- Around line 17-18: The two eligibility tiers "0 – 6 months" and "6 months – 1
year" overlap at exactly 6 months; resolve this by making one side
exclusive—e.g., change the first tier label "0 – 6 months" to "0 – <6 months"
(or "0 – up to 5 months 30 days") so that the second tier "6 months – 1 year"
clearly applies at the 6-month mark; update the table entry containing "0 – 6
months" accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 42d29f83-ddc6-4d18-9d0f-c740e0f50b68

📥 Commits

Reviewing files that changed from the base of the PR and between cebedcd and 2b8b9c0.

📒 Files selected for processing (1)
  • docs/LEAVE_POLICY.md

Comment thread docs/LEAVE_POLICY.md
Comment thread docs/LEAVE_POLICY.md
Comment thread docs/LEAVE_POLICY.md
@williamrusdyputra
Copy link
Copy Markdown
Contributor Author

@zolotokrylin you can submit your time here

@zolotokrylin
Copy link
Copy Markdown
Member

@holdex pr submit-time 25m

@zolotokrylin zolotokrylin merged commit 21b21d9 into main Apr 30, 2026
5 checks passed
@zolotokrylin zolotokrylin deleted the docs/leave branch April 30, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants