Make waitForRequestBlock run every event loop #480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
try cancel block from a different session
test was occasionally hanging (maybe 1/1000 runs).I couldn't trace exactly why (even just adding log statements threw off the timing sufficiently to make it always pass) but a possible cause is that the loop in
waitForRequestBlock
skipped over the request, which in the previous code is possible if it's extremely short-lived (~1ms). By usingsetImmediate
that should no longer be possibleNote: also got rid of the unused opts argument