Apply a common codestyle + tooling to validate & enforce it#75
Open
sanderdlm wants to merge 4 commits into
Open
Apply a common codestyle + tooling to validate & enforce it#75sanderdlm wants to merge 4 commits into
sanderdlm wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be reviewed per commit. The first one 5da4f53 installs the CodeSniffer package and adds some configuration.
The second commit is optional, because it applies the PSR12 codestyle to the entire codebase: 88de30c
If you want to go with a different set of rules, we can omit the second commit and apply another one. I chose PSR12 because it is common in the PHP world and seemed like a good standard, but I'm open to others.