Add support for injection into .NET Core#9
Draft
Oreeeee wants to merge 1 commit into
Draft
Conversation
Owner
|
Thanks for the PR! This looks good at first glance, but I don't have a Windows machine to test on right now so I don't know when I can get around to properly testing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently probably not ready for merge, so I'm drafting it for now. Injecting into a 64-bit process running on .NET 10 worked.
A few issues:
Note: A lot of code is shared with the .NET Framework implementation (basically a copy paste almost). It did not feel fitting to inherit from FrameworkInjectorBase though, and a lot of methods are implemented inside of CreateCallStub method. I feel like some of these should be separated into another class?
Closes #3