bgp: AS-path edge knobs (remove-private-as, allowas-in, as-override, local-as) - #144
Open
gusbourg wants to merge 3 commits into
Open
bgp: AS-path edge knobs (remove-private-as, allowas-in, as-override, local-as)#144gusbourg wants to merge 3 commits into
gusbourg wants to merge 3 commits into
Conversation
Keep the production spawn_protocol_task signature stable while routing testing-only channels through an internal helper. Also provide the testing-mode TimeoutTask constructor needed by workspace tests on this base.
Apply remove-private-as, allow-own-as, as-override, and local-as handling in the BGP decision and egress paths. Keep AS-path mutations on per-advertisement copies, present local-as in OPEN messages, and add focused unit coverage for each knob.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four per-neighbor AS-path edge knobs (previously deviated), via
ietf-bgpneighbor/peer-group config:all, andreplace-as(private replaced by local AS, path length preserved) modes.no-prependandreplace-asvariants.Unit tests cover each knob and variant:
allow_own_asboundary, the three private-AS modes, the local-as prepend forms, and as-override.🤖 Generated with Claude Code