Skip to content

feat: threefold hub api token#73

Merged
mattyg merged 1 commit intomainfrom
feat/threefold-api-token
Mar 12, 2026
Merged

feat: threefold hub api token#73
mattyg merged 1 commit intomainfrom
feat/threefold-api-token

Conversation

@mattyg
Copy link
Member

@mattyg mattyg commented Mar 11, 2026

Add threefold hub api token to wind-tunnel-runner.

Summary by CodeRabbit

  • New Features
    • Added Threefold Hub API token support so deployment workflows can securely access Threefold Hub services.
    • The token is now provisioned and integrated into repository deployment setups, enabling automated tasks to authenticate against the Threefold Hub without manual secret configuration.

@mattyg mattyg requested a review from a team March 11, 2026 03:13
@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9d9984ed-3aa5-4344-b278-7b463e2fe1eb

📥 Commits

Reviewing files that changed from the base of the PR and between 55ecbd4 and 8254a56.

📒 Files selected for processing (2)
  • Pulumi.github.yaml
  • main.go

Walkthrough

Adds a public configuration key holochain:threefoldHubApiToken in Pulumi.github.yaml and a new exported function AddThreefoldHubApiToken(ctx, cfg, repository) in main.go; the function is invoked for the wind-tunnel-runner repository to create the THREEFOLD_HUB_API_TOKEN GitHub Actions secret.

Changes

Cohort / File(s) Summary
Threefold Hub API Token
Pulumi.github.yaml, main.go
Added new config key holochain:threefoldHubApiToken (secure) and implemented AddThreefoldHubApiToken() plus its invocation for wind-tunnel-runner to provision the THREEFOLD_HUB_API_TOKEN Actions secret.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • ThetaSinner
  • cdunster
  • jost-s
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: threefold hub api token' directly describes the main change: adding a new token configuration for threefold hub API, which matches the changeset modifications in both Pulumi.github.yaml and main.go.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/threefold-api-token
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Mar 11, 2026

🍹 preview on holochain/holochain/github

Pulumi report

View in Pulumi Cloud

  Previewing update (holochain/github)

View Live: https://app.pulumi.com/holochain/holochain/github/previews/04f3bfbd-52d6-408a-a68d-741121972764

pulumi:pulumi:Stack: (same)
  [urn=urn:pulumi:github::holochain::pulumi:pulumi:Stack::holochain-github]
  + github:index/actionsSecret:ActionsSecret: (create)
      [urn=urn:pulumi:github::holochain::github:index/actionsSecret:ActionsSecret::wind-tunnel-runner-threefold-hub-api-token]
      [provider=urn:pulumi:github::holochain::pulumi:providers:github::default_6_11_0::dce38a79-6242-43ba-a5ff-26fae2b6f93c]
      destroyOnDrift: true
      plaintextValue: [secret]
      repository    : "wind-tunnel-runner"
      secretName    : "THREEFOLD_HUB_API_TOKEN"
Resources:
  + 1 to create
  376 unchanged
  

@mattyg mattyg force-pushed the feat/threefold-api-token branch from 55ecbd4 to 8254a56 Compare March 12, 2026 23:00
@mattyg mattyg enabled auto-merge (rebase) March 12, 2026 23:00
@cocogitto-bot
Copy link

cocogitto-bot bot commented Mar 12, 2026

✔️ 8254a56 - Conventional commits check succeeded.

@mattyg mattyg merged commit 508364f into main Mar 12, 2026
3 of 4 checks passed
@mattyg mattyg deleted the feat/threefold-api-token branch March 12, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants