Skip to content

feat: threefold tfchain wallet mnemonic#74

Merged
mattyg merged 1 commit intomainfrom
feat/threefold-mnemonic
Mar 12, 2026
Merged

feat: threefold tfchain wallet mnemonic#74
mattyg merged 1 commit intomainfrom
feat/threefold-mnemonic

Conversation

@mattyg
Copy link
Member

@mattyg mattyg commented Mar 11, 2026

Add our tfchain wallet mnemonic to wind-tunnel repo, so we can deploy nodes from CI

Summary by CodeRabbit

  • Chores
    • Updated credential configuration to support wallet-based authentication instead of previous token approach
    • Implemented automated secret initialization workflow for wallet credentials within GitHub Actions
    • Enhanced repository initialization process to include wallet credential configuration and setup
    • Improved credential management infrastructure for better security and integration

@mattyg mattyg requested a review from a team March 11, 2026 22:38
@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

Walkthrough

The PR replaces a configuration entry for Claude Code OAuth token with a Threefold TF Chain wallet mnemonic and adds a corresponding GitHub Actions secret setup function for the wind-tunnel repository, following existing patterns in the codebase.

Changes

Cohort / File(s) Summary
Threefold TF Chain Wallet Secret Configuration
Pulumi.github.yaml, main.go
Added configuration entry holochain:threefoldTfChainWalletMnemonic and implemented AddThreefoldTfChainWalletMnemonic helper function to create the THREEFOLD_TFCHAIN_WALLET_MNEMONIC GitHub Actions secret for the wind-tunnel repository; integrated function call into main initialization flow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • ThetaSinner
  • jost-s
  • cdunster
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: threefold tfchain wallet mnemonic' directly reflects the main change: adding a new Threefold tfchain wallet mnemonic secret and configuration to support node deployment from CI in the wind-tunnel repository.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/threefold-mnemonic

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mattyg mattyg changed the title feat: threefold tfchian wallet mnemonic feat: threefold tfchain wallet mnemonic Mar 11, 2026
@mattyg mattyg force-pushed the feat/threefold-mnemonic branch from 7849b51 to d93bb21 Compare March 11, 2026 22:38
@cocogitto-bot
Copy link

cocogitto-bot bot commented Mar 11, 2026

✔️ d93bb21 - Conventional commits check succeeded.

@github-actions
Copy link

github-actions bot commented Mar 11, 2026

🍹 preview on holochain/holochain/github

Pulumi report

View in Pulumi Cloud

  Previewing update (holochain/github)

View Live: https://app.pulumi.com/holochain/holochain/github/previews/5f84a934-e859-46ec-bfde-14d85a433616

pulumi:pulumi:Stack: (same)
  [urn=urn:pulumi:github::holochain::pulumi:pulumi:Stack::holochain-github]
  + github:index/actionsSecret:ActionsSecret: (create)
      [urn=urn:pulumi:github::holochain::github:index/actionsSecret:ActionsSecret::wind-tunnel-threefold-tfchain-wallet-mnemonic]
      [provider=urn:pulumi:github::holochain::pulumi:providers:github::default_6_11_0::dce38a79-6242-43ba-a5ff-26fae2b6f93c]
      destroyOnDrift: true
      plaintextValue: [secret]
      repository    : "wind-tunnel"
      secretName    : "THREEFOLD_TFCHAIN_WALLET_MNEMONIC"
Resources:
  + 1 to create
  375 unchanged
  

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
main.go (1)

1801-1810: Consider adding "Secret" suffix for naming consistency.

The function implementation is correct, but other single-secret helper functions in this file follow a naming convention ending with Secret (e.g., AddClaudeCodeOauthTokenSecret, AddNomadAccessTokenSecret). Consider renaming to AddThreefoldTfChainWalletMnemonicSecret for consistency.

✨ Optional: Rename function for consistency
-func AddThreefoldTfChainWalletMnemonic(ctx *pulumi.Context, cfg *config.Config, repository string) error {
+func AddThreefoldTfChainWalletMnemonicSecret(ctx *pulumi.Context, cfg *config.Config, repository string) error {

And update the call site at Line 153:

-		if err = AddThreefoldTfChainWalletMnemonic(ctx, conf, "wind-tunnel"); err != nil {
+		if err = AddThreefoldTfChainWalletMnemonicSecret(ctx, conf, "wind-tunnel"); err != nil {
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@main.go` around lines 1801 - 1810, Rename the helper function
AddThreefoldTfChainWalletMnemonic to AddThreefoldTfChainWalletMnemonicSecret to
match the existing naming convention for single-secret helpers (e.g.,
AddClaudeCodeOauthTokenSecret, AddNomadAccessTokenSecret); update the function
definition and all call sites that invoke AddThreefoldTfChainWalletMnemonic to
use AddThreefoldTfChainWalletMnemonicSecret so references remain consistent and
build succeeds.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@main.go`:
- Around line 1801-1810: Rename the helper function
AddThreefoldTfChainWalletMnemonic to AddThreefoldTfChainWalletMnemonicSecret to
match the existing naming convention for single-secret helpers (e.g.,
AddClaudeCodeOauthTokenSecret, AddNomadAccessTokenSecret); update the function
definition and all call sites that invoke AddThreefoldTfChainWalletMnemonic to
use AddThreefoldTfChainWalletMnemonicSecret so references remain consistent and
build succeeds.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4d2f7805-693a-4f09-a50b-c0cb164ab0bd

📥 Commits

Reviewing files that changed from the base of the PR and between af1eec5 and d93bb21.

📒 Files selected for processing (2)
  • Pulumi.github.yaml
  • main.go

@mattyg mattyg merged commit bcfa04c into main Mar 12, 2026
4 checks passed
@mattyg mattyg deleted the feat/threefold-mnemonic branch March 12, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants