This repository was archived by the owner on Feb 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This PR
holochain_core_types
'sCargo.toml
to use the 2018 edition of Rust (ca02f6c)use
declarations caused by the changes to namespacing in the 2018 edition (ca02f6c)extern crate
s because the 2018 edition makes them unneeded (ca02f6c)#[macro_use] extern crate
s and addsuse
declarations for their macros where needed (88af2fe)Foo<'_>
notation in accordance with 2018 edition idioms (575c348)testing/benchmarking notes
N/A
followups
I plan to make more of these for all crates that aren't 2018 in this mono-repo.
changelog
documentation