Sim2h recording & playback of connections and messages #2030
Conversation
…in-rust into sim2h-status-additions
…nto sim2h-walkman
…into sim2h-walkman
…into sim2h-walkman
…into sim2h-walkman
|
This is panicking on |
|
looks like status_check test is failing. From Standup we can just remove this test. |
MDD: TODO maybe bring this back one day
|
I think this is still failing to connect because it's getting back a closed connection from sim2h and then panicking on |
| @@ -78,102 +74,3 @@ pub fn sim2h_client(url_string: String, message_string: String) -> Result<(), St | |||
| thread_local! { | |||
| pub static CRYPTO: Box<dyn CryptoSystem> = Box::new(SodiumCryptoSystem::new()); | |||
| } | |||
| struct Job { | |||
There was a problem hiding this comment.
I'm not sure why this section is moved or if that's what we want @maackle ?
crates/sim2h_client/src/lib.rs
Outdated
| } | ||
| } | ||
| Err(e) if e.would_block() => None, | ||
| Err(e) => panic!(e), |
There was a problem hiding this comment.
This is the line that is panicking.
I think this whole file needs to be matched to sim2h_client.rs in develop
|
I'm not sure what the next move is with this. Basically the socket is busy from walkman's side then it timesout after 10 seconds. We could raise the timeout but I'm not sure why it's saying it's busy |
|
Actually it should probably just try connecting to a new socket if it times out |
PR summary
Initial hookup for recording key Sim2h events in log files, and then parsing those logs and playing them back using sim2h_client rather than real conductors.
See crates/walkman_cli/README.md for usage info
Recording:
Playback:
testing/benchmarking notes
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation