This repository was archived by the owner on Feb 3, 2023. It is now read-only.
Open
Conversation
Contributor
|
this doesn't work until the next version of holonix is cut and included |
thedavidmeister
approved these changes
Jan 4, 2020
Contributor
thedavidmeister
left a comment
thedavidmeister
left a comment
There was a problem hiding this comment.
newest holonix includes perf so this should work
struktured
approved these changes
Jan 6, 2020
thedavidmeister
suggested changes
Jan 6, 2020
Contributor
thedavidmeister
left a comment
thedavidmeister
left a comment
There was a problem hiding this comment.
@AshantiMutinta actually i had a look and flamegraph exists in nix pkgs we should use it
Contributor
Author
|
Wont work without this release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
-Added profiling tools for running perf under conductor and sim2h_server
-Added tools for generating flame graph
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation