This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Open
Conversation
alexanderattar
suggested changes
May 15, 2024
Contributor
alexanderattar
left a comment
There was a problem hiding this comment.
I think we will not merge this until we also have the script to fix previously deployed contracts. At the moment though we are also blocked on merging this until the tests are passing successfully @Yashiru so please try to focus on resolving those
Contributor
Author
…nership structure
…op-to-use-new-ownership Feature/udpate holograph drop to use new ownership
…lity-tests Feature/holo 1480 compatibility tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Changes
I changed the ownership management in the HolographERC721 and the CountdownERC721.
owner()orgetOwnerfunction of the enforcer contractChecklist before requesting a review