Conversation
| @@ -0,0 +1,218 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity 0.8.13; | |||
There was a problem hiding this comment.
Nice. Thanks for adding this fixture. I think it'll be great if we can make all the tests relatively consistent
There was a problem hiding this comment.
Yes you are right, I'd like to improve/refactor the entire foundry test base to standardize everything and make it consistent.
But we'll have to wait until everything has been migrated from hardhat to foundry I think.
wdyt ?
There was a problem hiding this comment.
yeah probably. we can do what we can on the tests we're writing but we probably shouldn't touch what the Think and Dev team are done until they reach a good stopping point
alexanderattar
left a comment
There was a problem hiding this comment.
Nice. This looks good!
sogoiii
left a comment
There was a problem hiding this comment.
Can this also be applied to the ERC20 contracts?
Describe Changes
I updated all the ERC721 sources contracts to make them store the payload used in their initialization.
For each source contracts
Note
The initPayload could be directly storaged ass a struct type for each contracts, but in the
CountdownERC721and theCustomERC721contracts, build failed with a stack too deep error in the constructors. So to create a "standard" in all contracts, I opted for a private storage variable of typebytesand a getter function to decode the bytes. This also made it possible to have a getter function named according to each contract.Checklist before requesting a review