This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Refactor 01_ValidateDeployChain1.t.sol and 02_ValidateDeployChain2.t.sol#347
Open
Refactor 01_ValidateDeployChain1.t.sol and 02_ValidateDeployChain2.t.sol#347
Conversation
djaciel
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Changes
Refactor
01_ValidateDeployChain1.t.soltestSampleERC20andtestSampleERC721don't pass because bytecodes don't match. This task is on hold until this problem can be resolved.Refactor
02_ValidateDeployChain2.t.soltestCxipERC721ProxyandtestHolographGenesisdon't pass because bytecodes don't match. This task is on hold until this problem can be resolved.Checklist before requesting a review