This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Improvement/holo 603 gas optimization combine address mappings#82
Draft
alexanderattar wants to merge 7 commits intotestnetfrom
Draft
Improvement/holo 603 gas optimization combine address mappings#82alexanderattar wants to merge 7 commits intotestnetfrom
alexanderattar wants to merge 7 commits intotestnetfrom
Conversation
Contributor
Author
|
@ACC01ADE I realize the gas savings from this might not be much as the values are not used in the same function and don't fit into the same slot, but this was my way of picking something easy up to get more comfortable updating the contracts before getting into more complicated stuff. If we feel that the potential gas savings don't justify the introduction of the new struct types / ergonomic changes of accessing the values, it's fine to not integrate these changes. lmk what you think |
Contributor
Author
|
You can see some calls that have some gas savings in the screenshots below |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
Contributor
Author
…bine-address-mappings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Describe Changes
Checklist before requesting a review