Skip to content

Add Panel Material UI announcement post #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

philippjfr
Copy link
Contributor

Initial draft

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@philippjfr philippjfr force-pushed the pmui_announcement branch from fcecbfb to 42c82ed Compare May 12, 2025 13:49
@philippjfr philippjfr force-pushed the pmui_announcement branch from 42c82ed to 3319c9c Compare May 12, 2025 14:14
Copy link
Contributor

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I made edits, but github's PR editing is doing strange things with this notebook; maybe it's not cleared and it's hiding that fact in the PRs? Confusing, but hopefully it's clear what I'm suggesting.

Copy link
Contributor

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In What can it do?, you might want to highlight that panel-material-ui can be used to replace templates.

It may just be me but I've been confused in general and specially in Panel with how to differentiate theme vs style vs design. It'd be nice to have some sort of introduction to these concepts for the beginner Panel user in the blog, showing how panel-material-ui helps to streamline all of this.
https://panel.holoviz.org/explanation/styling/design.html

@philippjfr
Copy link
Contributor Author

Thanks folks, I think I've addressed all the comments.

@Coderambling
Copy link

Just read through it @philippjfr . Looks great!

Suggestions:

— while staying fully compatible with your existing Panel code.

Will the be explained in more detail in this post or somewhere else?

Does compatible mean: a user can import both libraries, and mix and match existing and Material components in the same code?

Or what is meant by "compatible"? Especially existing Panel users might wonder what this means for their current code.

The What's next paragraph could maybe (additionally called migration / transition? Or a separate paragraph with this title?

@philippjfr
Copy link
Contributor Author

Added a small section about compatibility.

@MarcSkovMadsen
Copy link

Overall great post. The text to visual ratio is very high. I would include some more pictures, videos or .gifs to prove the main points:

  • light/ dark theme client side
  • Branding is possible
  • You can create advanced, custom dashboard templates
  • Custom material ui components
  • New, exiting components
  • Chat components are there

@MarcSkovMadsen
Copy link

I would recommend reviewing the mobile experience too. The Page with sidebar example is hard to understand visually and some plots do not render on my iPhone.

@philippjfr
Copy link
Contributor Author

I suspect the output just loaded too slowly when you reviewed it? Because most of those examples are there, branding, chat, and custom components and templates could also be mentioned though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants