-
Notifications
You must be signed in to change notification settings - Fork 5
Add Panel Material UI announcement post #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
fcecbfb
to
42c82ed
Compare
42c82ed
to
3319c9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I made edits, but github's PR editing is doing strange things with this notebook; maybe it's not cleared and it's hiding that fact in the PRs? Confusing, but hopefully it's clear what I'm suggesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In What can it do?, you might want to highlight that panel-material-ui can be used to replace templates.
It may just be me but I've been confused in general and specially in Panel with how to differentiate theme vs style vs design. It'd be nice to have some sort of introduction to these concepts for the beginner Panel user in the blog, showing how panel-material-ui helps to streamline all of this.
https://panel.holoviz.org/explanation/styling/design.html
Thanks folks, I think I've addressed all the comments. |
Just read through it @philippjfr . Looks great! Suggestions:
Will the be explained in more detail in this post or somewhere else? Does compatible mean: a user can import both libraries, and mix and match existing and Material components in the same code? Or what is meant by "compatible"? Especially existing Panel users might wonder what this means for their current code. The What's next paragraph could maybe (additionally called migration / transition? Or a separate paragraph with this title? |
Added a small section about compatibility. |
Overall great post. The text to visual ratio is very high. I would include some more pictures, videos or .gifs to prove the main points:
|
I would recommend reviewing the mobile experience too. The Page with sidebar example is hard to understand visually and some plots do not render on my iPhone. |
I suspect the output just loaded too slowly when you reviewed it? Because most of those examples are there, branding, chat, and custom components and templates could also be mentioned though. |
Initial draft